-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade Ruff 0.16.2 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,4 +47,9 @@ foo = [1] | |
| bar = foo | ||
| foo += [2] | ||
| assert (foo, bar) == ([1, 2], [1, 2]) | ||
| An augmented assignment can also fail where the plain form succeeds. NumPy | ||
| writes the result into the target's buffer, so a *= b raises where | ||
| a = a * b would broadcast to a new shape or promote the dtype. The same | ||
| applies to a @= b, which requires the product to have the target's shape. | ||
| The fix replaces the whole statement, so any comments inside it are lost. | ||
|
Comment on lines
+50
to
+54
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 MEDIUM RISK Move the descriptive text on lines 50-54 outside the triple-backtick code block (after line 55) to ensure it renders correctly as prose rather than Python code. |
||
| ``` | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,4 +24,8 @@ def test_foo(): | |
| def test_bar(): | ||
| assert not something | ||
| assert not something_else | ||
| Fix safety | ||
| On stable, the rule's fix is always unsafe and not offered when it would remove comments in the | ||
| compound assertion. In preview, the fix is only unsafe when it would delete such comments and | ||
| safe otherwise. | ||
|
Comment on lines
+27
to
+30
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 MEDIUM RISK Move the 'Fix safety' section (lines 27-30) outside the triple-backtick code block (after line 31) so that it is properly formatted as a Markdown header and text. |
||
| ``` | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| ruff==0.16.0 | ||
| jsonpickle==4.1.1 | ||
| numpy==2.3.2 | ||
| pytest==8.4.1 | ||
| toml==0.10.2 | ||
|
|
||
| ruff==0.16.2 | ||
| jsonpickle==4.1.2 | ||
| numpy==2.5.2 | ||
| pytest==9.1.1 | ||
| toml==0.10.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚪ LOW RISK
Nitpick: Remove the redundant '#Ignore vscode AI rules' comment and move the '.idea/' entry to a generic section for IDE-specific files, as it is related to JetBrains IDEs rather than VS Code.