You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
major - experiment/agent-conversation-profile.mjs:805: shellToolGroupFor now returns per-subcommand groups like loc_status and loc_diff, but the existing profiler test still asserts the old aggregate bash_loc group and folded stack names. This will fail once the test can run in a normal writable temp environment. Minimal fix: update experiment/agent-conversation-profile.test.mjs expected summaries/folded stacks for the new grouping, or preserve bash_loc if that aggregate name is still the intended contract.
major - experiment/locality-mcp-comparison/scripts/run-natural-retrieval-batch.mjs:21: LOC_BIN is computed but never exposed to the spawned Codex run, while the Locality strategy prompt tells the agent to run bare loc. The documented runner only adds $HOME/.cargo/bin to PATH, so environments where the repo build exists at target/debug/loc but no installed loc is on PATH will make loc search/status/diff fail or silently turn the Locality strategy into files-only. Minimal fix: validate LOC_BIN, pass it through, and either prepend dirname(LOC_BIN) to the spawned PATH or instruct the prompt to use $LOC_BIN; add a smoke test that sets LOC_BIN to a non-PATH stub.
Verification: node --check passed for the new .mjs scripts. I could not run the profiler tests end-to-end in this sandbox because /tmp is read-only, causing mkdtemp to fail before assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core Reasoning:
2b4cd92
Summary
loc context buildas the workflow-first primitive for agents.Validation