feat(assistants): implement Codex rollout-based file attachment detection

docs/superpowers/tasks/2026-08-05-epmcdme-13885-codex-file-attachments/actual-complexity.json

@@ -0,0 +1,71 @@
+{
+  "task": "Implement Codex file attachment detection for CodeMie assistants by scanning rollout JSONL files matched by CWD realpath and dispatching to the existing upload pipeline.",
+  "generated": "2026-08-05T00:00:00Z",
+  "dimensions": {
+    "component_scope": {
+      "score": 3,
+      "label": "M",
+      "affected": "codexUploadsDetector (new CLI-service module), codex-message-types (Agent-Tool type definitions), chat index.ts (CLI dispatch logic)",
+      "layers": "CLI-Command, CLI-Service, Agent-Tool"
+    },
+    "requirements_clarity": {
+      "score": 2,
+      "label": "S",
+      "status": "Clear",
+      "gaps": null
+    },
+    "technical_risk": {
+      "score": 3,
+      "label": "M",
+      "risk_factors": "Two-pass JSONL extraction logic, image_wrapper_pattern inline text parsing for filename resolution, local_images[] fallback, OOM-safe base64 size estimation without full buffer allocation — no exact copy-paste precedent in codebase",
+      "mitigation": "Additive-only change; errors silently return empty array; existing upload pipeline reused unchanged; easily rolled back"
+    },
+    "file_change_estimate": {
+      "score": 2,
+      "label": "S",
+      "modified_files": 2,
+      "modified_file_list": [
+        "src/agents/plugins/codex/codex-message-types.ts",
+        "src/cli/commands/assistants/chat/index.ts"
+      ],
+      "new_files": 1,
+      "new_file_list": [
+        "src/cli/commands/assistants/chat/codexUploadsDetector.ts"
+      ],
+      "affected_dirs": [
+        "src/cli/commands/assistants/chat",
+        "src/agents/plugins/codex"
+      ]
+    },
+    "dependencies": {
+      "score": 1,
+      "label": "XS",
+      "new_packages": [],
+      "version_changes": []
+    },
+    "affected_layers": {
+      "score": 2,
+      "label": "S",
+      "layers_changed": ["CLI-Command", "Agent-Tool"],
+      "schema_migration": false,
+      "cross_system": false
+    }
+  },
+  "total": 13,
+  "size": "S",
+  "band_range": "10-14",
+  "files_changed": 3,
+  "routing": "writing-plans",
+  "key_reasoning": [
+    {
+      "dimension": "component_scope",
+      "reason": "Three components touched across two distinct layers: new codexUploadsDetector service module, extended codex-message-types type file, and modified chat index.ts dispatch. Additive and self-contained within the assistants chat subsystem."
+    },
+    {
+      "dimension": "technical_risk",
+      "reason": "No exact pattern to copy: two-pass JSONL extraction, realpath CWD matching across multiple session roots, filename resolution via image_wrapper_pattern text parsing or local_images fallback, and an OOM-safe size guard using arithmetic rather than Buffer allocation. Logic is novel but low-stakes — all errors return empty array and the upload pipeline is unchanged."
+    }
+  ],
+  "red_flags_applied": [],
+  "split_recommendation": null
+}

docs/superpowers/tasks/2026-08-05-epmcdme-13885-codex-file-attachments/code-review-check.json

@@ -0,0 +1,51 @@
+{
+  "schema": 1,
+  "gate_id": "code-review.check",
+  "decision": "approve",
+  "confidence": "low",
+  "rationale": "All three major findings from the final round are resolved in the fix-up commit. CR-001: imageOnlyIndex counter now increments only for input_image blocks. CR-002: two-pass scan anchors event_msg search to records at or before the response_item position. CR-003: Buffer.from allocation removed; size estimated via base64 length math, empty data URI guard added. Confidence remains low because the round carries forward no-spec from the final round.",
+  "risk_flags": [],
+  "business_review": [],
+  "standards_review": [
+    {
+      "standard": "Conventional Commits format",
+      "source": ".ai-run/guides/standards/git-workflow.md",
+      "status": "pass",
+      "notes": "Fix-up commit: 'fix(assistants): correct three bugs in Codex file attachment detection' — valid conventional commit format."
+    },
+    {
+      "standard": "TypeScript code quality",
+      "source": ".ai-run/guides/standards/code-quality.md",
+      "status": "pass",
+      "notes": "Fix-up changes: no new any casts, no missing return types, all imports unchanged."
+    },
+    {
+      "standard": "Security practices",
+      "status": "pass",
+      "notes": "Carried forward from final round — no changes to security surface in fix-up."
+    }
+  ],
+  "findings": [],
+  "finding_status": [
+    {
+      "id": "CR-001",
+      "status": "resolved",
+      "notes": "imageOnlyIndex replaces localImageIndex; increment is now inside the if (block.type === 'input_image') branch."
+    },
+    {
+      "id": "CR-002",
+      "status": "resolved",
+      "notes": "Two-pass scan: first pass finds response_item and records its index; second pass searches for event_msg only at indices <= responseItemIndex."
+    },
+    {
+      "id": "CR-003",
+      "status": "resolved",
+      "notes": "Buffer.from removed. Size computed via Math.ceil(base64Data.length * 3 / 4) - paddingChars. Empty data URI guard (if (!base64Data)) added before size check."
+    },
+    {
+      "id": "CR-004",
+      "status": "no_change_needed",
+      "notes": "Deferred — minor finding, not a blocking issue. Empty data URI guard added as part of CR-003 fix also partially addresses this."
+    }
+  ]
+}

docs/superpowers/tasks/2026-08-05-epmcdme-13885-codex-file-attachments/code-review-final.json

@@ -0,0 +1,77 @@
+{
+  "schema": 1,
+  "gate_id": "code-review.final",
+  "decision": "request-changes",
+  "confidence": "low",
+  "rationale": "Three major correctness bugs found in codexUploadsDetector.ts: (1) localImageIndex counter is shared between input_file and input_image blocks causing filename misalignment in mixed-attachment turns; (2) the backward scan independently locates targetResponseItem and targetEventMsg, so a follow-up user message severs the filename chain from the attachment turn; (3) Buffer.from() allocates the full decoded image before the 100 MB guard, which can OOM-fail and misclassify a valid attachment as invalid base64. Confidence is low because sdlc-light has no spec artifact — no acceptance criteria were available to audit.",
+  "risk_flags": [],
+  "business_review": [],
+  "standards_review": [
+    {
+      "standard": "Conventional Commits format",
+      "source": ".ai-run/guides/standards/git-workflow.md",
+      "status": "pass",
+      "notes": "All commits in range follow <type>(<scope>): <description> format. Feature commit: 'feat(assistants): implement Codex rollout-based file attachment detection'."
+    },
+    {
+      "standard": "TypeScript code quality",
+      "source": ".ai-run/guides/standards/code-quality.md",
+      "status": "pass",
+      "notes": "Exported function has explicit return type, interfaces use PascalCase, all imports use .js extension, no bare require(). File naming deviates from kebab-case guide (codexUploadsDetector.ts vs kebab-case) but matches the pre-existing claudeUploadsDetector.ts pattern in the same directory."
+    },
+    {
+      "standard": "Security practices",
+      "source": ".ai-run/guides/security/security-practices.md",
+      "status": "pass",
+      "notes": "No credentials or tokens logged. Base64 image data not echoed to console or logs (only metadata: fileName, mediaType, sizeKB). Data URIs sourced from trusted local Codex rollout files, not external input. Size limit enforced. No path traversal exposure (CWD from process.cwd())."
+    }
+  ],
+  "findings": [
+    {
+      "id": "CR-001",
+      "severity": "major",
+      "triage": "patch",
+      "file": "src/cli/commands/assistants/chat/codexUploadsDetector.ts",
+      "location": "extractAttachments() — the localImageIndex counter, lines 202–226",
+      "problem": "localImageIndex is incremented for every attachment block (including input_file), but local_images in CodexEventMsg contains only image paths; when input_file blocks precede input_image blocks in the same user turn, the image-filename lookups into local_images are offset by the number of file blocks.",
+      "impact": "In a mixed file+image upload (e.g., user attaches a PDF and a screenshot together), every input_image block following any input_file block receives the wrong local_images entry as its filename fallback, falling through to the generic 'attachment_N' name and discarding the real filename.",
+      "recommendation": "Use a separate imageOnlyIndex that increments only when block.type === 'input_image', and use that counter for local_images lookups.",
+      "sources": ["blind", "edge-case"]
+    },
+    {
+      "id": "CR-002",
+      "severity": "major",
+      "triage": "patch",
+      "file": "src/cli/commands/assistants/chat/codexUploadsDetector.ts",
+      "location": "extractAttachments() — dual backward scan, lines 166–193",
+      "problem": "targetResponseItem and targetEventMsg are located by two independent predicates in a single backward scan that stops when both are found; when the user sends a follow-up text message after uploading a file in the same rollout, the scan finds the follow-up's event_msg (no local_images) while still finding the attachment's response_item, severing the local_images filename chain.",
+      "impact": "Any session where the user types a follow-up message after uploading an attachment will produce attachments with only the generic 'attachment_N' filename instead of the real filename for images whose preceding input_text block does not contain the wrapper pattern.",
+      "recommendation": "After locating targetResponseItem, search backward for an event_msg only among records at a lower index than the response_item, so both records are anchored to the same conversation turn.",
+      "sources": ["blind", "edge-case"]
+    },
+    {
+      "id": "CR-003",
+      "severity": "major",
+      "triage": "patch",
+      "file": "src/cli/commands/assistants/chat/codexUploadsDetector.ts",
+      "location": "processImageBlock() — Buffer.from call, line 139",
+      "problem": "Buffer.from(base64Data, 'base64') allocates the full decoded buffer (up to ~75 MB) solely to obtain .length before the size guard is applied; on memory-constrained environments this throws, and the catch block misclassifies a valid attachment as 'Invalid base64 data'.",
+      "impact": "A legitimate image just under the 100 MB limit can be silently dropped and logged as malformed base64 when the process is under memory pressure, with no indication that detection failed due to allocation rather than data corruption.",
+      "recommendation": "Pre-check size with Math.ceil(base64Data.length * 3 / 4) (minus trailing '=' chars) and bail before Buffer.from if the estimate exceeds MAX_FILE_SIZE_BYTES; only allocate for images that pass the guard.",
+      "sources": ["blind", "edge-case"]
+    },
+    {
+      "id": "CR-004",
+      "severity": "minor",
+      "triage": "defer",
+      "file": "src/cli/commands/assistants/chat/codexUploadsDetector.ts",
+      "location": "processImageBlock(), lines 127–155",
+      "problem": "An image_url of the form 'data:image/png;base64,' (comma present, empty payload) passes all guards and returns a structurally valid DetectedFile with data: '' and sizeBytes: 0.",
+      "impact": "A downstream SDK call receives a well-formed DetectedFile whose data field is an empty string; any code that forwards this as an image will silently produce a zero-byte attachment without an error at detection time.",
+      "recommendation": "Add a guard after extracting base64Data — if (!base64Data) { logger.warn(…); return null; } — to reject empty data URIs.",
+      "sources": ["edge-case"]
+    }
+  ],
+  "dismissed_count": 1,
+  "dismissed_note": "E-003 (Claude path no longer uses --conversation-id for file detection) dismissed — this behavior change is intentional per cherry-picked commit bfb011c8 'fix(assistants): always use CODEMIE_SESSION_ID for file detection, not --conversation-id' from EPMCDME-13907, which is the documented correct behavior."
+}

docs/superpowers/tasks/2026-08-05-epmcdme-13885-codex-file-attachments/events.jsonl

@@ -0,0 +1,2 @@
+{"event":"lifecycle_emission","intent":"artifact_published","artifact_kind":"plan","status":"succeeded"}
+{"event":"lifecycle_emission","intent":"record_complexity_score","assessment_mode":"actual","status":"succeeded"}