chore: update fallback driver docs URLs - #435
Merged
Merged
Conversation
Member
Author
|
Do we still need these hard-coded? Should we add the docs URLs for all the other known drivers? |
Member
|
We don't need this functionality any more. The CDN now validates on commit and in CI that every driver in the CDN has a documentation URL. I'll merge this and pull the fallback functionality out. |
amoeba
changed the title
amoeba
approved these changes
Jul 22, 2026
amoeba
added a commit
that referenced
this pull request
Jul 23, 2026
Removes the fallback URL functionality from the `dbc docs` subcommand. We needed this in the past because the Columnar driver CDN didn't have a method to enforce that every driver has a documentation URL. We now do and it's enforced in pre-commit and in CI. The behavior for any registry that doesn't set a docs URL for every driver remains unchanged: We still error with a "no documentation available..." error. Ref #435 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.