fix: improve error message for locking failures - #447
Merged
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain dbc subcommands use filesystem locks to avoid problems related to running multiple copies of dbc at the same time. The locking mechanism currently doesn't distinguish between a real locking failure and not being able to create the lock file in the first place. This can happen if the user tries to run a command like
dbc install --level system foowithout admin privs.This PR adds a specialized error
ErrLockContendedfor lock contention that our fslock implementation can use as a sentinel error and wraps existing calls in a helper functionacquireLockthat is responsible for handling errors from fslock and printing something more useful to the user than what's currently printed. Additionally, the new, more helpful error also suggests trying the command again with the appropriate mechanism for the user's operating system.Closes #446