feat: improve input modal#148
Merged
wendyyuchensun merged 2 commits intoJun 29, 2026
Merged
Conversation
…dals Set type="url" on all URL fields (link, embed, target) for correct mobile keyboards and semantics. Add noValidate to the modal <form> so custom, translated, role="alert" error messaging stays the single validation path instead of the browser's transient native bubbles. On a failed submit, move focus to the first invalid field across the iframe, link, and image modals so keyboard and screen-reader users are taken to the error rather than left on the submit button. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
wendyyuchensun
changed the title
wendyyuchensun
changed the title
jamliaoo
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asForm屬性，且當asForm=true時，「確認」按鈕改為type="submit"，讓使用者在任一欄位按 Enter 即可送出填答內容。type="url"，讓 input 的語意更完整。