fix: keep page height fixed and scroll editor/preview panes internally#151
Merged
Conversation
Pin the editor/preview area to viewport height and let each pane scroll internally instead of growing the document: - Wrap Home in a flex-column app shell (lg:h-screen lg:overflow-hidden) with main as flex-1, so panes fill viewport-minus-header without a hard-coded height. - Make editor box and preview box flex-1 + min-h-0 so they scroll internally; preview box matches editor box height. - Give preview box `relative` so see-mark's absolutely-positioned .sr-only MathML spans clip here instead of resolving against the viewport and adding phantom page scroll. - EditIconsTab fills its container (h-full) and adds min-h-0 on flex ancestors so the category/template lists scroll to the last item instead of overflowing.
wendyyuchensun
changed the title
jamliaoo
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題
設計師希望「空狀態的轉換結果高度，應該要跟編輯題目區域同高 ; 若內容超過高度，應該要有 scroll bar 可以滾動」。
https://docs.google.com/document/d/1o80SD1jfOYbKEKcX0WodZ-PL8xgvA8Xii2GAVOXJzYc/edit?tab=t.0
變更
relative，讓 see-mark 產生的.sr-onlyMathML span 實際位置不會超出預覽區。Demo
Before
After
Screen.Recording.2026-06-22.at.13.55.09.mov