Conversation
fedgiac
reviewed
Jul 7, 2026
fedgiac
left a comment
Contributor
There was a problem hiding this comment.
Looks good!
I didn't know about the COPYING files, but looks good.
Despite the link, I'm still not sure whether we're supposed to update the copyright notice in the GPL licenses themselves. 🙈
But I suppose not because that's the copyright of the license file itself?
How I checked the license files
No important diffs found with other versions of these files found online:
~$ diff <(curl --silent 'https://www.gnu.org/licenses/gpl-3.0.txt') <(curl --silent 'https://raw.githubusercontent.com/cowprotocol/solana-programs/license/COPYING.GPL')
674a675
>
~$ diff <(curl --silent 'https://www.gnu.org/licenses/lgpl-3.0.txt') <(curl --silent 'https://raw.githubusercontent.com/cowprotocol/solana-programs/license/COPYING.LESSER')
~$ diff <(curl --silent 'https://www.apache.org/licenses/LICENSE-2.0.txt') <(curl --silent 'https://raw.githubusercontent.com/cowprotocol/solana-programs/license/COPYING.APACHE')
1d0
<
$ diff <(curl --silent 'https://raw.githubusercontent.com/WisTex/The-MIT-License-Files/refs/heads/main/LICENSE') <(curl --silent 'https://raw.githubusercontent.com/cowprotocol/solana-programs/license/COPYING.MIT')
3c3
< Copyright (c) 2022 WisTex TechSero Ltd. Co.
---
> Copyright (c) 2026 CoW Foundation
fedgiac
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the LGPL 3.0, MIT, and Apache 2.0 licenses to the repo, and link the relevant disclosures and package attribution where necessary.
How to test
Verify that the license text is correct.
Verify that we have followed the relevant steps for our repo as documented by GNU (excluding the individual source file warnings, as im leaving that as out of scope for now since its a bigger project/decision) https://www.gnu.org/licenses/gpl-howto.en.html, and we are following standard patterns for the other two licenses.
Verify that the license is properly linked in our project workspace and packages.
Verify the readme notice is OK.