Update form sources and controls #7538 - #2109
Open
alhambrav wants to merge 13 commits into
Open
Conversation
WalkthroughConfiguration references for form controls and form data sources were reformatted from shared includes and compact tables into explicit Sphinx ChangesDocumentation table modernization
Estimated code review effort: 2 (Simple) | ~15 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 9
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@source/by-role/developer/common/content-modeling/form-controls/form-dropdown.rst`:
- Around line 64-65: Remove the empty table row represented by the standalone “*
-” and “-” lines in the form-dropdown documentation, leaving the surrounding
table structure and the “Related Data Sources” content unchanged.
In
`@source/by-role/developer/common/content-modeling/form-sources/form-source-components.rst`:
- Around line 58-61: Update the Tags entry in the property table to describe how
tags affect which components are accepted or browsable, instead of repeating
“Tags” as its description. Keep the explanation concise and consistent with the
surrounding Content Types documentation.
In
`@source/by-role/developer/common/content-modeling/form-sources/form-source-image-desktop.rst`:
- Around line 26-28: Update the image directive’s :alt: value near the desktop
form source configuration content to accurately describe the image, replacing
“Form Control Input 1” with “Form Source Image From Desktop Configuration” or an
equivalent page-specific description.
In
`@source/by-role/developer/common/content-modeling/form-sources/form-source-kvp.rst`:
- Around line 50-51: Update the “Show keys” row in the property table to include
a clear description of the behavior controlled by this option; if the option is
not configurable, remove the row instead.
In
`@source/by-role/developer/common/content-modeling/form-sources/form-source-mediaconvert-transcode.rst`:
- Around line 46-49: Replace the inconsistent profile descriptions with
grammatical “configured in aws.xml” wording: update both MediaConvert and S3
descriptions in
source/by-role/developer/common/content-modeling/form-sources/form-source-mediaconvert-transcode.rst
lines 46-49, the S3 description in
source/by-role/developer/common/content-modeling/form-sources/form-source-s3-file-repo.rst
lines 45-46,
source/by-role/developer/common/content-modeling/form-sources/form-source-s3-file-upload.rst
lines 48-49, and
source/by-role/developer/common/content-modeling/form-sources/form-source-s3-image-repo.rst
lines 45-46, plus the WebDAV descriptions in
source/by-role/developer/common/content-modeling/form-sources/form-source-webdav-file-upload.rst
lines 47-48,
source/by-role/developer/common/content-modeling/form-sources/form-source-webdav-image-repo.rst
lines 47-48,
source/by-role/developer/common/content-modeling/form-sources/form-source-webdav-image-upload.rst
lines 48-49, and
source/by-role/developer/common/content-modeling/form-sources/form-source-webdav-video-repo.rst
lines 48-49.
In
`@source/by-role/developer/common/content-modeling/form-sources/form-source-s3-file-repo.rst`:
- Around line 22-25: Replace the WebDAV configuration image reference with the
S3 configuration screenshot in all three affected files:
source/by-role/developer/common/content-modeling/form-sources/form-source-s3-file-repo.rst
lines 22-25,
source/by-role/developer/common/content-modeling/form-sources/form-source-s3-file-upload.rst
lines 25-28, and
source/by-role/developer/common/content-modeling/form-sources/form-source-s3-image-repo.rst
lines 22-25.
In
`@source/by-role/developer/common/content-modeling/form-sources/form-source-s3-image-upload.rst`:
- Around line 46-47: Correct the profile descriptions in
source/by-role/developer/common/content-modeling/form-sources/form-source-s3-image-upload.rst
lines 46-47,
source/by-role/developer/common/content-modeling/form-source-s3-video-repo.rst
lines 45-46, and
source/by-role/developer/common/content-modeling/form-source-s3-video-upload.rst
lines 48-49 to “S3 profile ID configured in aws.xml.” Update
source/by-role/developer/common/content-modeling/form-sources/form-source-webdav-file-repo.rst
lines 47-48 to “WebDAV profile ID configured in webdav.xml.”
- Around line 23-26: Replace the WebDAV configuration image references with the
appropriate S3-specific assets: use the S3 image-upload asset in
source/by-role/developer/common/content-modeling/form-sources/form-source-s3-image-upload.rst
lines 23-26, the S3 video-repository asset in
source/by-role/developer/common/content-modeling/form-sources/form-source-s3-video-repo.rst
lines 22-25, and the S3 video-upload asset in
source/by-role/developer/common/content-modeling/form-sources/form-source-s3-video-upload.rst
lines 25-28; preserve the existing image alignment, width, and alt-text
structure.
In
`@source/by-role/developer/common/content-modeling/form-sources/form-source-webdav-video-upload.rst`:
- Around line 46-49: Update the “Profile Id” description in the documentation
table to clearly state that it is the WebDAV profile ID configured in
`webdav.xml`, correcting the current wording without changing the surrounding
entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c4f6a70c-e9ce-4b83-89da-9326a47f0f0d
📒 Files selected for processing (49)
source/by-role/developer/common/content-modeling/form-controls/form-auto-filename.rstsource/by-role/developer/common/content-modeling/form-controls/form-checkbox.rstsource/by-role/developer/common/content-modeling/form-controls/form-date-time.rstsource/by-role/developer/common/content-modeling/form-controls/form-dropdown.rstsource/by-role/developer/common/content-modeling/form-controls/form-filename.rstsource/by-role/developer/common/content-modeling/form-controls/form-grouped-checkboxes.rstsource/by-role/developer/common/content-modeling/form-controls/form-image.rstsource/by-role/developer/common/content-modeling/form-controls/form-input.rstsource/by-role/developer/common/content-modeling/form-controls/form-internal-name.rstsource/by-role/developer/common/content-modeling/form-controls/form-item-selector.rstsource/by-role/developer/common/content-modeling/form-controls/form-label.rstsource/by-role/developer/common/content-modeling/form-controls/form-locale-selector.rstsource/by-role/developer/common/content-modeling/form-controls/form-numeric-input.rstsource/by-role/developer/common/content-modeling/form-controls/form-page-order.rstsource/by-role/developer/common/content-modeling/form-controls/form-repeating-group.rstsource/by-role/developer/common/content-modeling/form-controls/form-rte.rstsource/by-role/developer/common/content-modeling/form-controls/form-section.rstsource/by-role/developer/common/content-modeling/form-controls/form-text-area.rstsource/by-role/developer/common/content-modeling/form-controls/form-time.rstsource/by-role/developer/common/content-modeling/form-controls/form-transcoded-video.rstsource/by-role/developer/common/content-modeling/form-controls/form-video.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-audio-desktop.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-audio-repo.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-components.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-embedded-content.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-file-browse.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-file-desktop.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-image-desktop.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-image-repo.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-kvp.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-mediaconvert-transcode.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-s3-file-repo.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-s3-file-upload.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-s3-image-repo.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-s3-image-upload.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-s3-video-repo.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-s3-video-upload.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-shared-content.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-simple-taxonomy.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-video-desktop.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-video-repo.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-webdav-file-repo.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-webdav-file-upload.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-webdav-image-repo.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-webdav-image-upload.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-webdav-video-repo.rstsource/by-role/developer/common/content-modeling/form-sources/form-source-webdav-video-upload.rstsource/includes/form-controls/form-control-field-basics.rstsource/includes/form-sources/form-source-field-basics.rst
💤 Files with no reviewable changes (2)
- source/includes/form-sources/form-source-field-basics.rst
- source/includes/form-controls/form-control-field-basics.rst
alhambrav
marked this pull request as ready for review
July 23, 2026 13:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket reference or full description of what's in the PR
Update form sources and controls properties presentation craftersoftware/craftercms#7538