Skip to content

Add Arabic/Farsi/Urdu interval preset to font builder#20

Open
rxmmah wants to merge 2 commits into
crosspoint-reader:masterfrom
rxmmah:feat/add-arabic-intervals
Open

Add Arabic/Farsi/Urdu interval preset to font builder#20
rxmmah wants to merge 2 commits into
crosspoint-reader:masterfrom
rxmmah:feat/add-arabic-intervals

Conversation

@rxmmah

@rxmmah rxmmah commented Jul 14, 2026

Copy link
Copy Markdown
  • Adds 'arabic' preset in INTERVAL_PRESETS covering Arabic (U+0600-06FF),
    Arabic Supplement (U+0750-077F), Arabic Extended-A (U+08A0-08FF), and
    Arabic Presentation Forms-A/B (U+FB50-FDFF, U+FE70-FEFF) for Persian/
    Urdu letter coverage.
  • Adds matching checkbox in the font builder UI.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@rxmmah, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 14 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 84de65f8-c6bc-4c9b-9c97-48e25f0595b2

📥 Commits

Reviewing files that changed from the base of the PR and between 9afea64 and 746ff34.

📒 Files selected for processing (1)
  • scripts/font-builder/fontconvert_sdcard.py
📝 Walkthrough

Walkthrough

The font builder now supports Arabic Unicode intervals, and the fonts page documents and exposes an Arabic preset covering Arabic, Farsi, and Urdu.

Changes

Arabic font coverage

Layer / File(s) Summary
Define Arabic Unicode ranges
scripts/font-builder/fontconvert_sdcard.py
Adds Arabic, Arabic Supplement, Arabic Extended-A, and Arabic Presentation Forms to INTERVAL_PRESETS["arabic"].
Expose Arabic preset in fonts UI
public/fonts.html
Adds Arabic coverage guidance and an “Arabic (Farsi, Urdu)” checkbox preset.
Estimated code review effort: 1 (Trivial) ~3 minutes

Possibly related PRs

Suggested reviewers: uxjulia, itsthisjustin

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding an Arabic/Farsi/Urdu interval preset to the font builder.
Description check ✅ Passed The description is directly related to the changes and accurately mentions the new preset and matching UI checkbox.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Uri-Tauber

Uri-Tauber commented Jul 14, 2026

Copy link
Copy Markdown
Member

One thing: @YouHusam intentionally skipped on U+FDFD.
See his comment crosspoint-reader/crosspoint-reader#2541 (comment)

U+FDFD is a Unicode codepoint whose official name is "ARABIC LIGATURE BISMILLAH AR-RAHMAN AR-RAHEEM." It doesn't represent a letter or even a normal ligature — it's a single glyph that renders the entire opening phrase of the Quran, "بسم الله الرحمن الرحيم" ("In the name of God, the Most Gracious, the Most Merciful"), as one decorative unit. Font designers who want to support that traditional calligraphic rendering bake a whole-phrase glyph into the font at that codepoint. It's part of the "Arabic Presentation Forms-A" block (U+FB50–FDFF), tucked in among normal per-letter contextual forms.
Why it broke the converter?

@rxmmah

rxmmah commented Jul 14, 2026

Copy link
Copy Markdown
Author

@Uri-Tauber i corrected this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants