fix(docker): allow spaces in ENROLL_INSTANCE_NAME#4582
Conversation
Signed-off-by: sahilnyk <contactsahilpnayak@gmail.com>
|
@sahilnyk: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@sahilnyk: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
/kind bug |
|
/area configuration |
|
/kind fix |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4582 +/- ##
==========================================
- Coverage 64.31% 64.30% -0.02%
==========================================
Files 499 499
Lines 38537 38537
==========================================
- Hits 24786 24780 -6
- Misses 11427 11429 +2
- Partials 2324 2328 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Setting
ENROLL_INSTANCE_NAMEto a value with spaces crashes the container on startup. The entrypoint builds the enroll flags as a string and expands them unquoted, soENROLL_INSTANCE_NAME="foo bar"word-splits into two args and cscli fails:Since the script runs under
set -e, this aborts before crowdsec starts. Fixed by building the flags as an array so the name stays a single argument.Fixes #4330