Skip to content

Revert "Misc audit" - #608

Open
cigamit wants to merge 1 commit into
mainfrom
revert-606-misc_audit
Open

Revert "Misc audit"#608
cigamit wants to merge 1 commit into
mainfrom
revert-606-misc_audit

Conversation

@cigamit

@cigamit cigamit commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Reverts #606

Even though it works fine in Dev, pinning brace-extension to a newer version breaks minimatch during the build process.

file:///tmp/src/awx/ui/node_modules/inject-manifest-plugin/node_modules/minimatch/dist/esm/index.js:1
import expand from 'brace-expansion';
SyntaxError: The requested module 'brace-expansion' does not provide an export named 'default'

This reverts commit 16c0025.
@cigamit
cigamit requested a review from TheWitness July 29, 2026 02:29
@cigamit cigamit self-assigned this Jul 29, 2026
Copilot AI review requested due to automatic review settings July 29, 2026 02:29
@cigamit cigamit added dependencies Pull requests that update a dependency file SECURITY A security related issue like a CVE specifically javascript Pull requests that update javascript code labels Jul 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the prior “Misc audit” dependency updates that introduced a build-time incompatibility between minimatch and brace-expansion, restoring a dependency set that builds reliably in the awx/ui frontend.

Changes:

  • Removed the brace-expansion override that forced a newer incompatible release.
  • Reverted package-lock.json dependency resolutions to the pre-audit versions to avoid the minimatch import/export failure.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
awx/ui/package.json Removes the brace-expansion override that triggered the minimatch ESM import failure.
awx/ui/package-lock.json Reverts the lockfile’s resolved dependency graph to avoid pulling the incompatible brace-expansion/minimatch combination.
Files not reviewed (1)
  • awx/ui/package-lock.json: Generated file

Comment thread awx/ui/package-lock.json
"jest-websocket-mock": "^2.5.0",
"mini-css-extract-plugin": "^2.10.2",
"postcss": "^8.5.18",
"postcss": "^8.5.15",
Comment thread awx/ui/package-lock.json
Comment on lines 84 to 88
"jest-watch-typeahead": "^3.0.1",
"jest-websocket-mock": "^2.5.0",
"mini-css-extract-plugin": "^2.10.2",
"postcss": "^8.5.18",
"postcss": "^8.5.15",
"postcss-flexbugs-fixes": "^5.0.2",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code SECURITY A security related issue like a CVE specifically

Development

Successfully merging this pull request may close these issues.

2 participants