Revert "Misc audit" - #608
Open
cigamit wants to merge 1 commit into
Open
Conversation
This reverts commit 16c0025.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the prior “Misc audit” dependency updates that introduced a build-time incompatibility between minimatch and brace-expansion, restoring a dependency set that builds reliably in the awx/ui frontend.
Changes:
- Removed the
brace-expansionoverride that forced a newer incompatible release. - Reverted
package-lock.jsondependency resolutions to the pre-audit versions to avoid the minimatch import/export failure.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| awx/ui/package.json | Removes the brace-expansion override that triggered the minimatch ESM import failure. |
| awx/ui/package-lock.json | Reverts the lockfile’s resolved dependency graph to avoid pulling the incompatible brace-expansion/minimatch combination. |
Files not reviewed (1)
- awx/ui/package-lock.json: Generated file
| "jest-websocket-mock": "^2.5.0", | ||
| "mini-css-extract-plugin": "^2.10.2", | ||
| "postcss": "^8.5.18", | ||
| "postcss": "^8.5.15", |
Comment on lines
84
to
88
| "jest-watch-typeahead": "^3.0.1", | ||
| "jest-websocket-mock": "^2.5.0", | ||
| "mini-css-extract-plugin": "^2.10.2", | ||
| "postcss": "^8.5.18", | ||
| "postcss": "^8.5.15", | ||
| "postcss-flexbugs-fixes": "^5.0.2", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #606
Even though it works fine in Dev, pinning brace-extension to a newer version breaks minimatch during the build process.