fix: [1136] 11keyの譜面で11L, 11ikeyモードでプレイしたときに割当先の譜面がおかしくなる問題を修正

[cwtickle]

🔨 変更内容 / Details of Changes

1. fix: 11keyの譜面で11L, 11ikeyモードでプレイしたときに割当先の譜面がおかしくなる問題を修正

• 11keyの譜面で11L, 11ikeyモードでプレイしたとき、割当先がおかしくなっていました。
  この問題を修正しています。
• 11keyのキーパターン2をver44.1.0で増やしましたが、そのときに全体的に別キーモードのキーパターン番号が変わりました。基本的にはその対応を行っていましたが、g_keyObj.chara11_Xのみ設定が反映されていませんでした。

🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes

1. Discordでの指摘より。

📷 スクリーンショット / Screenshot

📝 その他コメント / Other Comments

• v44.1.0が原因の不具合になります。

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 815dfba8-d0e5-41a0-be96-b30c2836e15d

📥 Commits

Reviewing files that changed from the base of the PR and between 7b75302 and 8adc537.

📒 Files selected for processing (1)

• js/lib/danoni_constants.js

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Corrected key-pattern mappings for select 11-key play configurations.
  • Added support for the chara11L_2 pattern and preserved lane ordering for existing patterns.

Walkthrough

The PR updates g_keyObj with a new chara11L_2 pattern and renames the existing 11-key pattern from chara11_2 to chara11_3.

Changes

11-key pattern mapping

Layer / File(s)	Summary
Update 11-key mappings js/lib/danoni_constants.js	Adds chara11L_2 and renames the existing mapping to chara11_3. Both mappings preserve the same 11-lane ordering.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• cwtickle/danoniplus#1868: Both PRs modify g_keyObj 11-key pattern mappings in js/lib/danoni_constants.js.

Suggested labels: func:KeyConfig

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the fix for incorrect chart assignments in 11L and 11ikey modes.
Description check	✅ Passed	The description explains the incorrect assignment issue, its v44.1.0 cause, and the related key-pattern mapping fix.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch hotfix/1136-11key-another

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.45.0)

js/lib/danoni_constants.js

ast-grep timed out on this file

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}