build(deps): unify CoreGo to one version across all four go-render modules#35
Conversation
display/webkit and engine/php were pinned to older dappco.re/* releases (v0.11.0 and v0.10.4 respectively) than the go/ library (v0.12.0), so the four modules couldn't share a go.work — MVS would force the max version onto engine/php's pre-core.Result code. Bump every dappco.re/* dependency to one version per module, resolving each ONCE and reusing it everywhere it's needed: dappco.re/go v0.12.0 (library's existing anchor) dappco.re/go/io v0.15.1 dappco.re/go/i18n v0.12.1 dappco.re/go/log v0.13.1 dappco.re/go/config v0.18.0 (webkit; already latest) dappco.re/go/webview v0.11.0 (webkit; already latest) dappco.re/go/cli v0.11.4 (engine/php; latest) engine/php's go mod tidy dropped dappco.re/go/i18n (the code calls i18n via the core module's own I18n() service, not the standalone package — never a real dependency) and dappco.re/go/log/inference (no longer pulled transitively at the new version set). Neither module needed a core.Result cascade fix on their default build target: webkit's default set was already Result-shaped, and engine/php's pre-Result call sites live behind the frankenphp build tag (needs libphp/CGO headers absent here), out of this gate's reach. Extend go.work to all four modules and go work sync the graph. Sync also gave cli/ its first real go.mod requires (dappco.re/go, io, process@v0.16.1 latest) for deps it always imported but never declared. cli/ still can't build with GOWORK=off (imports its own sibling go/ library, resolved only via the workspace use directive by design — documented in this repo's own CLAUDE.md); that's pre-existing and unrelated to this unification. Co-Authored-By: Virgil <virgil@lethean.io>
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughChangesGo module dependency updates
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Unifies every
dappco.re/*(CoreGo) pin to one modern version so the four go-render modules compose in a single workspace (mixed versions made MVS force-upgrade old-API code).dappco.re/go→ v0.12.0,io→ v0.15.1 everywhere; webkit was v0.11.0, engine/php was v0.10.4.cli→ v0.11.4; droppedi18n/log/inference(pulled via core's own services, never directly imported).go.worknow unifies all four (./go ./cli ./display/webkit ./engine/php); wails + frankenphp untouched.core.Resultcascade needed — webkit was already Result-shaped; php's pre-Result call sites live behind//go:build frankenphp(out of the stub gate).Gates (
GOWORK=off): go/, display/webkit (cgo/Wails), engine/php (stub) all build+vet rc=0; workspace composes (go build all/ per-module rc=0). (Note:go build ./...from the workspace root hits a Go 1.26.5 quirk —./...won't expand from a non-module dir;go build allis the equivalent.)🤖 Generated with Claude Code
Co-Authored-By: Virgil virgil@lethean.io
Summary by CodeRabbit