Skip to content

fix: create /app before writing version (build is broken on main) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jtrotsky wants to merge 1 commit into from
Closed

fix: create /app before writing version (build is broken on main) #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Containerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ LABEL org.opencontainers.image.title="immich-cli" \
# prebuilt py311 wheels to dodge cargo). Pin the exact version for reproducibility.
RUN pkg update && pkg install -y ca_root_nss node22 npm-node22 \
&& npm install -g @immich/cli@${IMMICH_CLI_VERSION} \
&& npm list -g @immich/cli --depth=0 | sed 's/.*@//' > /app/version \
&& mkdir -p /app \
&& npm list -g @immich/cli --depth=0 | sed -n 's/.*@//p' > /app/version \
&& npm cache clean --force \
&& pkg clean -ay && rm -rf /var/cache/pkg/* /root/.npm

Expand All @@ -49,7 +50,7 @@ RUN pkg update && pkg install -y ca_root_nss node22 npm-node22 \
# Unprivileged runtime. /import is the conventional mount point for the media to
# upload (mounted read-only at run time). Server URL + key are supplied at run
# time via env (IMMICH_INSTANCE_URL, IMMICH_API_KEY) or `immich login`.
RUN chmod -R a+rX /usr/local/lib/node_modules \
RUN chmod -R a+rX /usr/local/lib/node_modules /app \
&& mkdir -p /import && chown -R bsd:bsd /import
USER bsd
WORKDIR /import
Expand Down
5 changes: 3 additions & 2 deletions Containerfile.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ LABEL org.opencontainers.image.title="immich-cli" \
# prebuilt py311 wheels to dodge cargo). Pin the exact version for reproducibility.
RUN pkg update && pkg install -y ca_root_nss node22 npm-node22 \
&& npm install -g @immich/cli@${IMMICH_CLI_VERSION} \
&& npm list -g @immich/cli --depth=0 | sed 's/.*@//' > /app/version \
&& mkdir -p /app \
&& npm list -g @immich/cli --depth=0 | sed -n 's/.*@//p' > /app/version \
&& npm cache clean --force \
&& pkg clean -ay && rm -rf /var/cache/pkg/* /root/.npm

Expand All @@ -43,7 +44,7 @@ RUN pkg update && pkg install -y ca_root_nss node22 npm-node22 \
# Unprivileged runtime. /import is the conventional mount point for the media to
# upload (mounted read-only at run time). Server URL + key are supplied at run
# time via env (IMMICH_INSTANCE_URL, IMMICH_API_KEY) or `immich login`.
RUN chmod -R a+rX /usr/local/lib/node_modules \
RUN chmod -R a+rX /usr/local/lib/node_modules /app \
&& mkdir -p /import && chown -R bsd:bsd /import
USER bsd
WORKDIR /import
Expand Down
Loading