fix: remove duplicate BTC_RPCPORT=8333 (use 8332) and drop build_0.1.6 artifacts#60
Merged
Conversation
…6 artifacts - docker-compose.yml had BTC_RPCPORT declared twice (8332 from PR #45 and 8333 from PR #48). Compose merges duplicate env keys last-wins, so the container actually received 8333 (the mainnet P2P port), conflicting with P2P_PORT=8340. Drop the 8333 entry; keep the 8332 entry from the original PR #45 'add rpcport as env' to match the entrypoint default (rpcport=${BTC_RPCPORT:-8332}) and the standard mainnet JSON-RPC port. - Remove stale build_0.1.6/ artifacts (avatar, tarballs, manifest, compose).
|
Dappnode bot has built and pinned the built packages to an IPFS node, for commit: 70d4cb3 This is a development version and should only be installed for testing purposes.
Hash: (by dappnodebot/build-action) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
docker-compose.ymldeclaredBTC_RPCPORTtwice:Docker Compose merges duplicate
environmentkeys last-wins, so thecontainer actually received
BTC_RPCPORT=8333. That is the mainnet P2Pport (and this package already maps P2P to 8340 via
P2P_PORT=8340),so the JSON-RPC server was attempting to bind the same port as the
peer-to-peer listener.
The entrypoint default in
src/docker_entrypoint.shis alreadyrpcport=${BTC_RPCPORT:-8332}, andEXPOSEdocuments 8332/8333,so the intended value is 8332 (the mainnet JSON-RPC port).
Fix
BTC_RPCPORT=8333line, keeping the originalBTC_RPCPORT=8332from PR bump bitcoin/bitcoin to v26.2 #45.build_0.1.6/artifacts (avatar, tarballs, manifest,compose) that should not have been tracked in git.
Verification
After this change:
bitcoin.confwill setrpcport=8332andbitcoindwill listenfor P2P traffic on 8340 — no port collision, matches the entrypoint
defaults and the standard mainnet convention.
Refs: PR #45 (8ea3d98), PR #48 (f0b0077)