Skip to content

ci: remove temporary linux64_ubsan workaround following #7503 - #7554

Merged
PastaPastaPasta merged 1 commit into
dashpay:developfrom
PastaPastaPasta:codex/remove-ubsan-workaround-7503
Aug 7, 2026
Merged

ci: remove temporary linux64_ubsan workaround following #7503#7554
PastaPastaPasta merged 1 commit into
dashpay:developfrom
PastaPastaPasta:codex/remove-ubsan-workaround-7503

Conversation

@PastaPastaPasta

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Follow-up to PR #7503. Removes the temporary CI matrix workaround for linux64_ubsan that mapped linux64_ubsan to 00_setup_env_native_asan.sh while testing #7503 before merge.

What was done?

Removed the elif [ "$BUILD_TARGET" = "linux64_ubsan" ]; then workaround block in ci/dash/matrix.sh.

How Has This Been Tested?

Ran test/lint/lint-shell.py locally.

This pull request was created by Codex.

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ed02774c-2aad-46ef-84e5-7555efaf845c

📥 Commits

Reviewing files that changed from the base of the PR and between 3c87ad2 and 1546b0b.

📒 Files selected for processing (1)
  • ci/dash/matrix.sh
💤 Files with no reviewable changes (1)
  • ci/dash/matrix.sh

Walkthrough

The CI matrix script no longer handles the linux64_ubsan build target. The change removes its legacy-workflow comments, temporary ASAN option override, and ASAN environment setup.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the removal of the temporary linux64_ubsan workaround after PR #7503.
Description check ✅ Passed The description explains the removed CI workaround, the affected file, the related PR, and the local lint test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

thepastaclaw commented Aug 7, 2026

Copy link
Copy Markdown

✅ Final review complete — no blockers (commit 1546b0b)

@knst knst left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 1546b0b

If CI succeed

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Codex + Sonnet

This is a trivial, purely mechanical CI cleanup that removes the temporary linux64_ubsan compatibility branch from ci/dash/matrix.sh, which was a documented workaround pending PR #7503's merge (already merged per the commit graph). Independently verified the diff, confirmed zero remaining references to linux64_ubsan anywhere in the repo (workflows now consistently use linux64_asan), and confirmed the script still executes cleanly. Both Codex and Sonnet reviewer lanes (general + commit-history) returned zero findings, and CodeRabbit posted no actionable inline comments — this assessment is unanimous and correct.
Source: reviewer backends codex-general gpt-5.6-sol, codex-dash-core-commit-history gpt-5.6-sol, sonnet-general claude-sonnet-5, sonnet-dash-core-commit-history claude-sonnet-5; final verifier backend claude-sonnet-5. openclaw-agent/cliproxy/gpt-5.6-sol is orchestration-only and is not reviewer evidence.

Review provenance

  • Codex reviewers: gpt-5.6-sol — general (completed), gpt-5.6-sol — dash-core-commit-history (completed)
  • Verifier: claude-sonnet-5 — final-verifier
  • Sonnet reviewers: claude-sonnet-5 — general (completed), claude-sonnet-5 — dash-core-commit-history (completed)

@PastaPastaPasta
PastaPastaPasta merged commit ff671c1 into dashpay:develop Aug 7, 2026
44 of 45 checks passed
@PastaPastaPasta PastaPastaPasta added this to the 24 milestone Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants