chore: bump rust-dashcore to the latest dev revision - #4381
Merged
Conversation
Move all eight rust-dashcore workspace dependencies (dashcore, dash-network-seeds, dash-spv, key-wallet, key-wallet-ffi, key-wallet-manager, dash-network, dashcore-rpc) from 37b1a361 to 36b49cb7, the current head of the upstream dev branch. The pin advances by a single upstream commit, "feat(dash-spv): accelerate compressed header sync" (dashpay/rust-dashcore#950). Its changes are confined to dash-spv internals and the headers2 network message decoder; the only edit to a public type is a doc comment on HashedBlockHeader::with_trusted_hash. No platform source changes were required to build against it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR updates eight ChangesRust Dashcore dependency pins
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
|
ℹ️ Review superseded (commit 33e845a) |
bfoss765
added a commit
that referenced
this pull request
Aug 12, 2026
Carries #4380 (dashpay profile payment addresses, breaking dpp) + #4381 (rust-dashcore pin bump) + the shield-preflight family. Resolutions: - platform_wallet.rs / shielded_send.rs: false overlaps — keep BOTH our identity_create_from_one_time_key surface and v4.2-dev's shielded_shield_preflight/plan additions. - Error-code collision: v4.2-dev allocated 37-40 to the DPNS marketplace block and 41 to the shield-capacity shortfall, colliding with our ErrorShieldedInviteAlreadyClaimed = 37. Renumbered ours to 43 on every surface (Rust FFI enum, Kotlin arm + test pin, Swift raw value), the allocation the integration branch already ships in QA AARs (42 stays reserved to match it). - DashSdkError.kt / PlatformWalletResult.swift: keep both sides' new error classes/cases, ours renumbered and ordered after the v4.2-dev blocks. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
bfoss765
added a commit
that referenced
this pull request
Aug 12, 2026
Carries #4380 (dashpay profile payment addresses) + #4381 (rust-dashcore pin bump). Conflict + pooled-funding reconciliation, mirroring the resolutions already proven on the integration branch: - identity/network/payments.rs: keep the in-broadcast refusal block, return the 5-tuple with offered_accounts, and sweep the release across every offered account (pooled selection) instead of the single managed_account. - asset_lock/build.rs: the refusal-path release now sweeps result.funding_accounts owner-guarded (the pre-merge single funding_account param no longer exists under pooled funding). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
The workspace was pinned to rust-dashcore
37b1a361, which had fallen behind the upstreamdevbranch. This brings the pin up to the currentdevhead so platform builds against the latest core.What was done?
Bumped all eight rust-dashcore workspace dependencies in
Cargo.tomlfrom37b1a361to36b49cb7f9c07ce8f2ed63f965489c50968d19f7, and regenerated the corresponding 12Cargo.lockentries withcargo update -w:dashcore,dash-network-seeds,dash-spv,key-wallet,key-wallet-ffi,key-wallet-manager,dash-network,dashcore-rpcThe pin advances by exactly one upstream commit:
feat(dash-spv): accelerate compressed header sync(dashpay/rust-dashcore#950).Reviewer notes
No platform source changes were needed. The upstream commit is confined to:
dash-spv/src/network/{manager,message_dispatcher}.rsdash-spv/src/sync/block_headers/{manager,pipeline,segment_state,sync_manager}.rsdash/src/network/message_headers2.rs(the headers2 decoder)dash-spv/tests/header_dispatch_order.rsThe only change touching a public type is a doc comment on
HashedBlockHeader::with_trusted_hashindash-spv/src/types.rs— no signature or behavioral change in the API surface platform consumes. The diff here is therefore limited toCargo.tomlandCargo.lock(20 insertions / 20 deletions).How Has This Been Tested?
Both run locally on macOS (arm64) against the new pin, exit codes checked directly rather than through a pipe:
cargo check --workspace --all-targets— cleancargo clippy --workspace --all-targets— exit 0, no lint warningsThe single warning emitted is the pre-existing
default-features is ignored for dashcoreCargo.toml note inrs-dpp, which is unrelated to this change and present before the bump.Test suites were not run locally; CI coverage is relied on for those. Since the upstream delta is header-sync logic inside dash-spv, the SPV/wallet suites are the ones worth watching on this PR.
Breaking Changes
None. No consensus-affecting code is touched, and no platform-side API changes were required.
Checklist:
For repository code-owners and collaborators only
🤖 Generated with Claude Code
Summary by CodeRabbit