Skip to content

chore: bump rust-dashcore to the latest dev revision - #4381

Merged
QuantumExplorer merged 1 commit into
v4.2-devfrom
claude/upgrade-rust-dash-core-f02a37
Aug 12, 2026
Merged

chore: bump rust-dashcore to the latest dev revision#4381
QuantumExplorer merged 1 commit into
v4.2-devfrom
claude/upgrade-rust-dash-core-f02a37

Conversation

@QuantumExplorer

@QuantumExplorer QuantumExplorer commented Aug 12, 2026

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

The workspace was pinned to rust-dashcore 37b1a361, which had fallen behind the upstream dev branch. This brings the pin up to the current dev head so platform builds against the latest core.

What was done?

Bumped all eight rust-dashcore workspace dependencies in Cargo.toml from 37b1a361 to 36b49cb7f9c07ce8f2ed63f965489c50968d19f7, and regenerated the corresponding 12 Cargo.lock entries with cargo update -w:

dashcore, dash-network-seeds, dash-spv, key-wallet, key-wallet-ffi, key-wallet-manager, dash-network, dashcore-rpc

The pin advances by exactly one upstream commit: feat(dash-spv): accelerate compressed header sync (dashpay/rust-dashcore#950).

Reviewer notes

No platform source changes were needed. The upstream commit is confined to:

  • dash-spv/src/network/{manager,message_dispatcher}.rs
  • dash-spv/src/sync/block_headers/{manager,pipeline,segment_state,sync_manager}.rs
  • dash/src/network/message_headers2.rs (the headers2 decoder)
  • a new upstream test, dash-spv/tests/header_dispatch_order.rs

The only change touching a public type is a doc comment on HashedBlockHeader::with_trusted_hash in dash-spv/src/types.rs — no signature or behavioral change in the API surface platform consumes. The diff here is therefore limited to Cargo.toml and Cargo.lock (20 insertions / 20 deletions).

How Has This Been Tested?

Both run locally on macOS (arm64) against the new pin, exit codes checked directly rather than through a pipe:

  • cargo check --workspace --all-targets — clean
  • cargo clippy --workspace --all-targets — exit 0, no lint warnings

The single warning emitted is the pre-existing default-features is ignored for dashcore Cargo.toml note in rs-dpp, which is unrelated to this change and present before the bump.

Test suites were not run locally; CI coverage is relied on for those. Since the upstream delta is header-sync logic inside dash-spv, the SPV/wallet suites are the ones worth watching on this PR.

Breaking Changes

None. No consensus-affecting code is touched, and no platform-side API changes were required.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated internal component versions to improve consistency and compatibility.
    • No user-facing features or behavior changes were introduced.

Move all eight rust-dashcore workspace dependencies (dashcore,
dash-network-seeds, dash-spv, key-wallet, key-wallet-ffi,
key-wallet-manager, dash-network, dashcore-rpc) from 37b1a361 to
36b49cb7, the current head of the upstream dev branch.

The pin advances by a single upstream commit, "feat(dash-spv):
accelerate compressed header sync" (dashpay/rust-dashcore#950). Its
changes are confined to dash-spv internals and the headers2 network
message decoder; the only edit to a public type is a doc comment on
HashedBlockHeader::with_trusted_hash. No platform source changes were
required to build against it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c8cf953-bbb8-411c-8642-3abcade9396e

📥 Commits

Reviewing files that changed from the base of the PR and between 441fb19 and 33e845a.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml

📝 Walkthrough

Walkthrough

The PR updates eight rust-dashcore workspace dependency pins in Cargo.toml to revision 36b49cb7f9c07ce8f2ed63f965489c50968d19f7.

Changes

Rust Dashcore dependency pins

Layer / File(s) Summary
Update rust-dashcore pins
Cargo.toml
Eight rust-dashcore dependencies now reference the new revision.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: shumkov, lklimek, zocolini

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the dependency revision update in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/upgrade-rust-dash-core-f02a37

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added this to the v4.2.0 milestone Aug 12, 2026
@thepastaclaw

thepastaclaw commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

ℹ️ Review superseded (commit 33e845a)
Last checked: 2026-08-12 15:50 UTC

@QuantumExplorer
QuantumExplorer merged commit 2e685f3 into v4.2-dev Aug 12, 2026
8 of 9 checks passed
@QuantumExplorer
QuantumExplorer deleted the claude/upgrade-rust-dash-core-f02a37 branch August 12, 2026 15:48
bfoss765 added a commit that referenced this pull request Aug 12, 2026
Carries #4380 (dashpay profile payment addresses, breaking dpp) + #4381
(rust-dashcore pin bump) + the shield-preflight family. Resolutions:

- platform_wallet.rs / shielded_send.rs: false overlaps — keep BOTH our
  identity_create_from_one_time_key surface and v4.2-dev's
  shielded_shield_preflight/plan additions.
- Error-code collision: v4.2-dev allocated 37-40 to the DPNS marketplace
  block and 41 to the shield-capacity shortfall, colliding with our
  ErrorShieldedInviteAlreadyClaimed = 37. Renumbered ours to 43 on every
  surface (Rust FFI enum, Kotlin arm + test pin, Swift raw value), the
  allocation the integration branch already ships in QA AARs (42 stays
  reserved to match it).
- DashSdkError.kt / PlatformWalletResult.swift: keep both sides' new
  error classes/cases, ours renumbered and ordered after the v4.2-dev
  blocks.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
bfoss765 added a commit that referenced this pull request Aug 12, 2026
Carries #4380 (dashpay profile payment addresses) + #4381 (rust-dashcore
pin bump). Conflict + pooled-funding reconciliation, mirroring the
resolutions already proven on the integration branch:

- identity/network/payments.rs: keep the in-broadcast refusal block,
  return the 5-tuple with offered_accounts, and sweep the release across
  every offered account (pooled selection) instead of the single
  managed_account.
- asset_lock/build.rs: the refusal-path release now sweeps
  result.funding_accounts owner-guarded (the pre-merge single
  funding_account param no longer exists under pooled funding).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants