added goldens EurostatData_Demographic_Balance_Crude_Rates#2083
Open
niveditasing wants to merge 2 commits into
Open
added goldens EurostatData_Demographic_Balance_Crude_Rates#2083niveditasing wants to merge 2 commits into
niveditasing wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a golden summary report and configures validation rules for Eurostat regional statistics on birth, death, and migration. Feedback was provided regarding an incorrect relative path to the golden summary report in the validation configuration, which would cause validation to fail.
niveditasing
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This import has recurring deletion failures less than 0.01%. To tackle these small deletions, the threshold has been increased, but we also added two new golden checks. These validation checks will verify that the data contains all sets in a golden set, these are defined within the validation_config.json file, which is situated in the same directory as manifest.json. The threshold has been raised to 0.05, a value determined by historical and current deletion percentages, with a small buffer to account for these minor deletions.
PR checklist: https://docs.google.com/spreadsheets/d/1BzweR9Sj58j0H2_BweGTmfE4Z1lrjPZL8u1FS0kzCeg/edit?pli=1&gid=0#gid=0