Skip to content

Adding Golden data to avoid missing reference failure#2085

Open
pravnkumar-cloudsufi wants to merge 1 commit into
datacommonsorg:masterfrom
cloudsufi:usda_agriculture
Open

Adding Golden data to avoid missing reference failure#2085
pravnkumar-cloudsufi wants to merge 1 commit into
datacommonsorg:masterfrom
cloudsufi:usda_agriculture

Conversation

@pravnkumar-cloudsufi

Copy link
Copy Markdown

@pravnkumar-cloudsufi

Copy link
Copy Markdown
Author

@gemini-code-assist

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a validation configuration and golden summary data for the US USDA QuickStats script. Specifically, it adds a new golden summary report CSV, references the validation configuration file in the manifest, and defines validation rules for deleted records and golden data checks. However, the relative path specified for the golden file in validation_config.json is incorrect and would lead to a file-not-found error; it should be updated to point directly to golden_data/golden_summary_report.csv.

Comment thread scripts/us_usda/quickstats/validation_config.json
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Hello! Adding golden data for validation is a great practice for maintaining the integrity of your data pipeline and preventing regressions. This approach ensures that any unexpected changes in the summary report output are caught early. Your implementation in the manifest and the validation configuration follows the standard patterns used in this repository. If you have any specific questions about the validation logic or need further assistance, feel free to ask!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant