Automation of import Finland_Census #2087
Open
smarthg-gi wants to merge 4 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request automates the import process for the Finland Demographics Dataset by introducing a data_download.py script to fetch data from the Statistics Finland PxWeb API and a run.sh script to orchestrate the download and processing. The README.md and manifest.json have been updated to document and support this automated refresh. Feedback on the changes suggests using the standard csv module in data_download.py to robustly parse headers containing commas, and quoting the wildcard pattern in run.sh to prevent unintended shell expansion.
smarthg-gi
changed the title
Contributor
|
@smarthg-gi : Please add golden checks to the validation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import name =
Finland_CensusPR checklist = Doc
Overview
Automation of Finland Demographics Dataset (
Finland_Census) understatvar_imports/.Key Changes
data_download.pywhich leverages existingutil/download_util.pyfor data download.run.shandmanifest.jsonwith the correct cron schedule and file paths to trigger the download and processing of the data.test_data/.Verification & Validation Proofs
Local CI Presubmit:
./run_tests.sh -apasses 100% (unit tests +yapf --style=googleformatting check).Verification:
stat_var_processor.pyexecuted againsttest_data/finland_census_input.csv;git diff test_data/is clean.Data Commons Lint Check: Executed
java -jar datacommons-import-tool.jar lint output_files/*.csv.Result: 0 errors, 0 warnings. All generated StatVar DCIDs and TMCF references conform to schema rules.