Adding golden files in cdc_nor_noninfectious#2088
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a golden summary report and a validation configuration file for US CDC non-infectious diseases, alongside updates to the manifest to integrate these validation settings. The review feedback identifies an incorrect relative path to the golden data file in the validation configuration that would lead to a failure, and suggests removing a redundant config_overrides block in the manifest.
| "validator": "GOLDENS_CHECK", | ||
| "params": { | ||
| "golden_files": [ | ||
| "../../../../golden_data/golden_summary_report.csv" |
There was a problem hiding this comment.
The relative path ../../../../golden_data/golden_summary_report.csv is incorrect.
Since validation_config.json is located at scripts/us_cdc/non_infectious_diseases/validation_config.json and the golden file is at scripts/us_cdc/non_infectious_diseases/golden_data/golden_summary_report.csv, the correct relative path from the configuration directory is "golden_data/golden_summary_report.csv".
Using ../../../../ would resolve to a directory outside the repository root, causing the validation to fail because the file cannot be found.
| "../../../../golden_data/golden_summary_report.csv" | |
| "golden_data/golden_summary_report.csv" |
| "validation_config_file": "validation_config.json", | ||
| "config_overrides": { | ||
| "validation_config_file": "validation_config.json" | ||
| } |
There was a problem hiding this comment.
The config_overrides block is redundant because it overrides validation_config_file with the exact same value (validation_config.json) that is already defined at the top level on line 23. Removing this block simplifies the manifest file.
"validation_config_file": "validation_config.json"1 participant
PR Checklist: