Fix templating on multiform body - #83
Open
alexbourret wants to merge 4 commits into
Open
Conversation
alexbourret
requested review from
yannickbetou-dku
and removed request for
yannickbetou-dku
July 27, 2026 07:35
Contributor
|
[sc-333719] |
Ellana42
self-requested a review
July 30, 2026 12:33
Ellana42
requested changes
Jul 30, 2026
| self.requests_kwargs.update({"files": {k: (None, v) for k, v in get_dku_key_values(key_value_body).items()}}) | ||
| files = {} | ||
| for key, value in get_dku_key_values(key_value_body).items(): | ||
| files[key] = (None, format_template(value, **self.presets_variables)) |
Contributor
There was a problem hiding this comment.
The code technically works but it the keyword replacement logic should be put downstream where it is for all the other formats IMO
(ie line 155). The issue is that format_template currently doesn't handle tuples. I think it would be cleaner to just modify it to handle them.
Collaborator
Author
There was a problem hiding this comment.
It could be made better but refacto of this part will take a lot more testing. I'll look into it when we have more time 🤞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.