Feat: Add Configurable Discovery Validation Capabilities#37
Draft
ClassicMMT wants to merge 1 commit into
Draft
Conversation
ClassicMMT
marked this pull request as draft
July 19, 2026 22:45
ClassicMMT
changed the title
ClassicMMT
force-pushed
the
configurable-discovery-validation
branch
2 times, most recently
from
July 20, 2026 03:15
8b85d87 to
ab9865a
Compare
ClassicMMT
force-pushed
the
configurable-discovery-validation
branch
from
July 20, 2026 20:10
ab9865a to
922e121
Compare
ClassicMMT
requested review from
kw-datamasque
and removed request for
kanewilliams
July 20, 2026 21:22
|
Some preliminary comments for now. Will give it a proper review once a few other PRs settle. |
kw-datamasque
requested changes
Jul 21, 2026
Comment on lines
+152
to
+153
| timeout: float = 60.0, | ||
| poll_interval: float = 1.0, |
There was a problem hiding this comment.
Magic numbers: Can we make these named constants with units in base.py and share with validate_discovery_config?
Suggested change
| timeout: float = 60.0, | |
| poll_interval: float = 1.0, | |
| timeout_seconds: float = VALIDATION_TIMEOUT_SECONDS, | |
| poll_interval_seconds: float = VALIDATION_POLL_INTERVAL_SECONDS, |
| """Validation status; may be `in_progress` briefly after creating a large config.""" | ||
| validation_error: Optional[str] = Field(default=None, exclude=True) | ||
| """Human-readable validation error, or `None` when valid.""" | ||
| validation_error_details: list[ValidationErrorDetails] = Field(default_factory=list, exclude=True) |
There was a problem hiding this comment.
ruleset_library.py has a very similar looking field (of list[ValidationErrorDetails]) named validation_errors
Although I prefer validation_error_details since it aligns with the type, for consistency should we rename to match?
Suggested change
| validation_error_details: list[ValidationErrorDetails] = Field(default_factory=list, exclude=True) | |
| validation_errors: list[ValidationErrorDetails] = Field(default_factory=list, exclude=True) |
Comment on lines
+34
to
+50
| def promote_error_locations(data: object) -> object: | ||
| """Flatten a server `errors` payload into a `validation_error_details` list.""" | ||
|
|
||
| if not isinstance(data, dict) or "errors" not in data: | ||
| return data | ||
| data = dict(data) | ||
| raw_errors = data.pop("errors") | ||
| entries: list[object] = [] | ||
| if isinstance(raw_errors, dict): | ||
| for value in raw_errors.values(): | ||
| if isinstance(value, list): | ||
| entries.extend(value) | ||
| elif isinstance(raw_errors, list): | ||
| entries = raw_errors | ||
| if entries: | ||
| data["validation_error_details"] = entries | ||
| return data |
There was a problem hiding this comment.
Could we declare the shape when defining validation_error_details and let pydantic do the parsing for us?
validation_error_details: list[ValidationErrorDetails] = Field(
default_factory=list,
exclude=True,
validation_alias=AliasChoices(AliasPath("errors", "config_yaml"), "validation_error_details"),
)(docs to pydantic aliasing) - Does this work?
| try: | ||
| delete() | ||
| except DataMasqueException: | ||
| logger.warning('Failed to clean up %s; remove it manually.', description) |
There was a problem hiding this comment.
The warning drops the underlying error, so finding the cause of it may be guesswork after it happens.
Suggestion: catch as e and include it in the message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for datamasque-cli PR.
Requires PR 36 being merged first or this branch merged into it.