fix(download): use setMethod('POST') for SPARQL wrapper#73
Open
Prakhar54-byte wants to merge 1 commit into
Open
fix(download): use setMethod('POST') for SPARQL wrapper#73Prakhar54-byte wants to merge 1 commit into
Prakhar54-byte wants to merge 1 commit into
Conversation
Using direct attribute assignment on SPARQLWrapper is silently ignored; the wrapper defaults to GET for all queries. Large SPARQL queries (e.g. those returned by collection endpoints) exceed GET URL-length limits and fail. The correct API is setMethod(). Also add setMethod() to the DummySPARQL test stub in conftest.py so the unit test suite does not break when the real API call is made. Closes #<BUG-02>
📝 WalkthroughWalkthroughThe ChangesSPARQL POST Method Fix
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #69
Using direct attribute assignment on
SPARQLWrapper(sparql.method = 'POST') is silently ignored by the wrapper, which defaults to GET. Large SPARQL queries (e.g. from collection endpoints) then exceed GET URL-length limits.This PR uses the correct
setMethod('POST')API, and updates theDummySPARQLtest stub to mock the method appropriately.Summary by CodeRabbit