Skip to content

fix(download): use numeric sort key for artifact version URLs#74

Open
Prakhar54-byte wants to merge 1 commit into
dbpedia:mainfrom
Prakhar54-byte:bug/version-sort
Open

fix(download): use numeric sort key for artifact version URLs#74
Prakhar54-byte wants to merge 1 commit into
dbpedia:mainfrom
Prakhar54-byte:bug/version-sort

Conversation

@Prakhar54-byte

@Prakhar54-byte Prakhar54-byte commented Jul 5, 2026

Copy link
Copy Markdown

Resolves #70

version_urls.sort(reverse=True) performs a plain lexicographic sort, which returns the wrong 'latest' version for semver-style IDs (e.g. 2.10.0 sorts before 2.9.0 as strings, making 2.9.0 the 'latest').

This PR adds a _parse_version_key() helper that splits the trailing URL segment on non-digit characters and compares each part as an integer, yielding correct numeric ordering. Date-style versions (e.g. 2022.12.01) continue to work correctly.

version_urls.sort(reverse=True) performs a plain lexicographic sort,
which returns the wrong 'latest' version for semver-style IDs:
  ['2.10.0', '2.9.0'] -> lexicographic latest is '2.9.0' (wrong)

Add _parse_version_key() which splits the trailing URL segment on
non-digit characters and compares each part as an integer, giving
correct numeric ordering with no new dependencies (re is stdlib).

Date-style versions (2022.12.01) continue to work correctly.

Closes #<BUG-05>
@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Prakhar54-byte, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3865a7e3-ed86-452e-93d6-eddae89f4144

📥 Commits

Reviewing files that changed from the base of the PR and between ca7ac2d and b17b7fd.

📒 Files selected for processing (1)
  • databusclient/api/download.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: lexicographic version sort returns wrong "latest" version for semver-style version IDs

1 participant