Skip to content

feat(download): add overall progress bar for multi-file downloads #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Prakhar54-byte wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

feat(download): add overall progress bar for multi-file downloads #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion databusclient/api/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,10 @@ def _download_files(
validate_checksum: Whether to validate checksums after downloading.
checksums: Dictionary mapping URLs to their expected checksums.
"""
for url in urls:
# Overall progress bar for multiple files
# We use position=0 so it stays at the top, while individual file progress
# bars (which are not given a position explicitly) will print below it.
for url in tqdm(urls, desc="Overall Progress", unit="file", position=0):
expected = None
if checksums and isinstance(checksums, dict):
expected = checksums.get(url)
Expand Down