ci: add zizmor pre-commit hook and harden workflows#1437
Open
adRn-s wants to merge 1 commit into
Open
Conversation
- Add zizmor pre-commit hook (.pre-commit-config.yaml) - Pin all GitHub Actions to commit SHAs (unpinned-uses) - Add persist-credentials: false to checkout steps (artipacked) - Add minimal top-level permissions to workflows (excessive-permissions)
Collaborator
Author
|
I didn't dare to push other hooks from template-py (i.e. ruff) but certainly it would be nice-to-have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds zizmor as a pre-commit hook and applies its fixes to the GitHub Actions workflows.
Changes
.pre-commit-config.yaml), pinned tov1.11.0.unpinned-uses, 35 findings).persist-credentials: falseon allactions/checkoutsteps so the token isn't left in.git/config(artipacked, 10 findings).permissions: contents: readonpypi.yml,test_planemo.yml,test_pytest.yml,test_rust.yml(excessive-permissions, 9 findings).wheels.ymlalready had one.Result
zizmor went from 38 findings (19 medium, 10 high) to 0 errors/warnings. One informational finding remains:
use-trusted-publishinginpypi.yml, which requires PyPI-side OIDC setup and was intentionally left out of this PR.