Skip to content

chore(webhook): pin local-webhook 0.10.1 so green CI stops spawning sessions #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lionello merged 1 commit into from
Aug 10, 2026
+38 −4
Merged

chore(webhook): pin local-webhook 0.10.1 so green CI stops spawning sessions #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/agent-box.nix
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions modules/agent-box.nix.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2099,7 +2099,7 @@ in
};
rev = lib.mkOption {
type = lib.types.str;
default = "efa253166074789ece9709e4a1e3a4be58801166";
default = "aec22b5878b19dca12de5c954e86302cd6c7bdd8";
description = ''
Pinned local-channels commit whose local-webhook/webhook.py the
receiver daemon and the agent-box-webhook CLI run. Claude sessions
Expand All @@ -2113,7 +2113,7 @@ in
# builtins.fetchurl hash of local-webhook/webhook.py at `rev`:
# nix-prefetch-url https://raw.githubusercontent.com/<repo>/<rev>/local-webhook/webhook.py
# then `nix hash convert --hash-algo sha256 --to sri <base32>`.
default = "sha256-qHVF398YAwiIqbYG2/HY+hVzY4HF4saiasdZHAXngIM=";
default = "sha256-fZKy5jCsn3bom9F4E3dqW7N7x9ky+IM4NXFzLLSBOtU=";
description = "builtins.fetchurl hash of the pinned local-webhook/webhook.py.";
};
};
Expand Down
34 changes: 34 additions & 0 deletions tests/webhook.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,40 @@
" agent-box-webhook unsubscribe defangdevs/agent-box"
)

# --- dispatch brake: a green run is not news (local-channels 0.10.1) -----
# Nobody owns the topic now and this sender is on no ignore list, so the
# OUTCOME is the only thing that can hold the spawn back. Pinned webhook.py
# before 0.10.1 read the outcome only to decide whether a CI event could
# override an ignored sender, and started a session per green build: one
# merge to master cost four hook-* sessions that each concluded "nothing to
# do", with the four-session cap then standing between a real failure and
# its triage.
client.succeed(
"cat > /tmp/green.json <<'EOF'\n"
'{"action":"completed","workflow_run":{"name":"CI","conclusion":"success",'
'"head_branch":"master","html_url":"https://box.test/run/2"},'
'"repository":{"full_name":"defangdevs/agent-box"},"sender":{"login":"someone"}}\n'
"EOF"
)
sig_green = client.succeed(
f"openssl dgst -sha256 -hmac {secret} -r /tmp/green.json | cut -d' ' -f1"
).strip()
client.succeed(
f"{curl} -o /dev/null -w '%{{http_code}}' -X POST"
" -H 'content-type: application/json' -H 'x-github-event: workflow_run'"
" -H 'x-github-delivery: test-green'"
f" -H 'x-hub-signature-256: sha256={sig_green}' --data-binary @/tmp/green.json"
" https://box.test/agent/webhook/github | grep -x 200"
)
machine.wait_until_succeeds(
"journalctl -u agent-box-webhook-agent --no-pager | grep -q 'no failing outcome'",
timeout=30,
)
machine.fail(
"jq -e '.sessions | keys | map(select(startswith(\"hook-\"))) | length > 0'"
" /home/agent/.config/agent-box/sessions.json"
)

# A signed delivery on the watched repo → a fresh hook-* session appears in
# sessions.json, primed with the framed event text plus the trusted
# preamble, and the supervisor starts it as a real tmux session.
Expand Down