docs: drop external TCP Service (keep Internal TCP Service)#59
Merged
Conversation
External TCP Service (the TCPService deployment type) needs a dedicated external IP + port, which the platform no longer offers, so it's no longer an offered deployment type. Stop advertising it in the docs while keeping InternalTCPService (a ClusterIP — no dedicated external IP/port, unaffected). - types.md: remove the external 'TCP service' at-a-glance row and '## TCP service' section; make '## Internal TCP service' self-contained; 'six kinds'→'five', 'opens a TCP port'→'opens an in-cluster TCP port', description wording. - automation/github-action.md + deploy-from-github.md: drop TCPService from the valid 'type' value lists; port row '(WebService/TCPService)'→ '(WebService/InternalTCPService)'. - concepts.md, introduction.md, access.md, configuration.md, _index.md: reword generic 'TCP service' mentions to 'internal TCP service'. Docs-only and scoped to de-advertising (the API still accepts the type for now; removing it from the code is a separate decision). The homepage card is handled in deploys-app/website#22. hugo extended build clean; no remaining external-TCP references; no dangling #tcp-service anchor links.
|
Preview deleted (PR closed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
External TCP Service (the
TCPServicedeployment type) needs a dedicated external IP + port, which the platform no longer offers — so it's no longer an offered deployment type. This de-advertises it across the docs while keeping InternalTCPService (a ClusterIP — no dedicated external IP/port, so unaffected).Changes (8 content files)
deployments/types.md— remove the external "TCP service" at-a-glance row and the## TCP servicesection; make## Internal TCP serviceself-contained (it previously read "Same as TCP service, but…"); frontmatter "six kinds of workloads" → "five", "opens a TCP port" → "opens an in-cluster TCP port", and the description's "…and TCP services" → "…and internal TCP services".automation/github-action.md+automation/deploy-from-github.md— dropTCPServicefrom the validtypevalue lists (keepInternalTCPService); port row(WebService/TCPService)→(WebService/InternalTCPService).getting-started/concepts.md,getting-started/introduction.md,deployments/access.md,deployments/configuration.md,deployments/_index.md— reword generic "TCP service(s)" mentions to "internal TCP service(s)" (introduction.md's table row retitled and its "exposed internally or externally" → "reachable from inside your cluster").Scope
TCPServicetype for now; removing it from the code (api/apiserver/deployer/console/CLI/mcp) is a separate decision.Verification
hugoextended build clean (exit 0).content/(onlyInternalTCPService/ "internal TCP service" remain).#tcp-serviceanchor links;[Routes]cross-link intact.