Name the tooltip close button for screen readers - #335
Open
rezabakhshilaktasaraei wants to merge 1 commit into
Open
Name the tooltip close button for screen readers#335rezabakhshilaktasaraei wants to merge 1 commit into
rezabakhshilaktasaraei wants to merge 1 commit into
Conversation
ilya-fedin
reviewed
Aug 10, 2026
rezabakhshilaktasaraei
force-pushed
the
tooltip-dismiss-label
branch
from
August 10, 2026 14:49
f626105 to
a1728c8
Compare
rezabakhshilaktasaraei
changed the title
rezabakhshilaktasaraei
force-pushed
the
tooltip-dismiss-label
branch
from
August 10, 2026 15:29
a1728c8 to
bd65b17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The close button in MakeTooltipWithClose had no accessible name, so screen readers announced it as just "button". Now it uses Integration::phraseButtonClose(), the same way the window title close button does.