Fix WebView dialog size feedback loop on Wayland - #147
Open
NEO-LAX wants to merge 1 commit into
Open
Conversation
NEO-LAX
marked this pull request as ready for review
July 31, 2026 14:44
Contributor
|
Are you sure the bug is here? The description sounds you're fixing manifestation instead of the root cause as setting to the same value shouldn't enlarge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VerticalLayout::heightValue()emission when sizing WebView dialogsProblem
For WebView confirmation dialogs on Wayland,
setInnerSize()can trigger another layout height update. Subscribing to everyheightValue()emission feeds that update back intosetInnerSize(), creating a positive size loop that rapidly stretches the dialog far beyond the monitor bounds.The content height is needed for the initial dialog size only. Taking the first emission breaks the feedback loop for both blocking and asynchronous popup paths.
Validation
masterbranch