More tests for IdentityService and AccountService#3
Open
maebeam wants to merge 3 commits into
Open
Conversation
lazynina
requested changes
Apr 30, 2021
lazynina
left a comment
lazynina
left a comment
Member
There was a problem hiding this comment.
Other than addressing the todos, this looks great.
Comment on lines
+147
to
+158
| // TODO: For some reason this is failing | ||
| // expect(lastPostMessage.payload.decryptedHexes).toEqual({ | ||
| // [encryptedHex]: message, | ||
| // }); | ||
| }); | ||
|
|
||
| it('can handle info', () => { | ||
| // TODO | ||
| }); | ||
|
|
||
| it('can handle jwt', () => { | ||
| // TODO |
Member
There was a problem hiding this comment.
We should address these todos before merging this in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.