Guard MSI UpgradeCode lookup against missing registry key#2
Merged
Tom Plant (pl4nty) merged 1 commit intoJul 4, 2026
Conversation
Get-ADTApplication built its MSI UpgradeCode lookup table with an unguarded Get-ChildItem on HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\Installer\UpgradeCodes. On machines where that key does not exist (e.g. images with no MSI-registered upgrade codes), Get-ChildItem threw a PathNotFound error that aborted the function's begin block, breaking any caller such as Uninstall-ADTApplication. Add -ErrorAction Ignore to match the pattern already used for the uninstall key enumeration. When the key is absent the pipeline yields no items, the scriptblock's begin/end blocks still run, and the lookup table is simply empty; downstream indexing already returns $null for GUIDs that are not present. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XLNM98Nd3HZLTWFatRVgB1
e657a79
into
fix/getadtapp-upgradecodes-missing
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get-ADTApplication built its MSI UpgradeCode lookup table with an unguarded Get-ChildItem on
HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\Installer\UpgradeCodes. On machines where that key does not exist (e.g. images with no MSI-registered upgrade codes), Get-ChildItem threw a PathNotFound error that aborted the function's begin block, breaking any caller such as Uninstall-ADTApplication.
Add -ErrorAction Ignore to match the pattern already used for the uninstall key enumeration. When the key is absent the pipeline yields no items, the scriptblock's begin/end blocks still run, and the lookup table is simply empty; downstream indexing already returns $null for GUIDs that are not present.
Claude-Session: https://claude.ai/code/session_01XLNM98Nd3HZLTWFatRVgB1
Pull Request
Description
Please include a summary of any changes. Please also include relevant motivation and context.
Fixes: #12345
Fixes: https://github.com/PSAppDeployToolkit/PSAppDeployToolkit/issues/12345
Type of change
Checklist
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.