chore: Angular 17-18 Migration and Complete Material 3 based UI Revamp#568
Open
sawankshrma wants to merge 21 commits into
Open
chore: Angular 17-18 Migration and Complete Material 3 based UI Revamp#568sawankshrma wants to merge 21 commits into
sawankshrma wants to merge 21 commits into
Conversation
ESLint 18 warning: Output bindings, including aliases, should not be named as standard DOM events
sawankshrma
force-pushed
the
angular_17-18
branch
from
f8abf3b to
67d9c1b
Compare
sawankshrma
force-pushed
the
angular_17-18
branch
from
67d9c1b to
0779cea
Compare
sawankshrma
force-pushed
the
angular_17-18
branch
from
0779cea to
790c6fb
Compare
sawankshrma
changed the title
sawankshrma
changed the title
wurstbrot
reviewed
Jun 22, 2026
wurstbrot
reviewed
Jun 22, 2026
wurstbrot
reviewed
Jun 22, 2026
vbakke
requested changes
Jun 22, 2026
vbakke
left a comment
vbakke
left a comment
Collaborator
There was a problem hiding this comment.
Looks pretty good @sawankshrma
In addition to @wurstbrot's comments, I see that the heatmap is throwing an error in the console when clicking on the chips.
…ied and the default background color is already appropriate
ran command npm install markdown-it@latest npm install -D @types/markdown-it@latest and then pinned to exact versions in package.json
sawankshrma
force-pushed
the
angular_17-18
branch
from
790c6fb to
fe1c6b6
Compare
Collaborator
Author
I am not being able to reproduce this error in console, Neither in chrome or firefox.... Edit:- I was able to reproduce the error and fix it in the commit below (c84d4bc) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
description is doc