refactor(up): modernize WithSignals with signal.NotifyContext#684
Conversation
Replace the hand-rolled context.WithCancel + signal goroutine with signal.NotifyContext for first-signal cancellation, matching the pattern already used in cmd/internal. The second-signal force-exit behavior is preserved via a small watchForForceShutdown helper. No behavior change.
✅ Deploy Preview for images-devsy-sh canceled.
|
✅ Deploy Preview for devsydev canceled.
|
|
Warning Review limit reached
Next review available in: 9 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
Modernizes
WithSignalsincmd/workspace/up/up.goto usesignal.NotifyContext(Go 1.16+) for first-signal cancellation, instead of the hand-rolledcontext.WithCancel+ signal-forwarding goroutine. This matches the pattern already used elsewhere in the repo (cmd/internal/daemon_local.go,cmd/internal/agentcontainer/daemon.go).The two-signal behavior is preserved: the first signal cancels the context (so deferred cleanup runs), and a second signal forces
os.Exit(1)via a smallwatchForForceShutdownhelper.No behavior change.
Context
Extracted from #603 per review feedback to keep that PR focused on the
devsy cifeature. This is a prerequisite refactor and targetsmaindirectly.