Skip to content

refactor(up): up command agent result error reconciliation#685

Merged
skevetter merged 1 commit into
mainfrom
refactor/validate-up-result
Jul 19, 2026
Merged

refactor(up): up command agent result error reconciliation#685
skevetter merged 1 commit into
mainfrom
refactor/validate-up-result

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

Centralizes how the agent-forwarded structured error is reconciled with the transport error in the up path:

  • Adds config.Result.Err() (nil-safe) and ErrNoAgentResult, so the result.Error != "" handling lives in one place instead of being duplicated across up.go and agent.go.
  • Splits executeDevsyUp into validateUpResult (result/err reconciliation) and resolveWorkdir (workspace-folder resolution), dropping the function below the cyclomatic-complexity threshold.
  • Adds a unit test for Result.Err().

No behavior change.

Context

Extracted from #603 per review feedback to keep that PR focused on the devsy ci feature. This is a prerequisite refactor and targets main directly.

Add config.Result.Err() and ErrNoAgentResult so the agent-forwarded structured
error is resolved in one place, and split executeDevsyUp into validateUpResult
+ resolveWorkdir. Removes the duplicated `result.Error != ""` check in up.go and
agent.go and drops executeDevsyUp below the cyclomatic-complexity threshold.
No behavior change.
@netlify

netlify Bot commented Jul 18, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit d3a2ef0
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a5bb1e9e8396b00088a3a17

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@skevetter, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 6 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bcbc22f1-7e58-4bbf-ab86-7242c0f140c0

📥 Commits

Reviewing files that changed from the base of the PR and between 789ddd8 and d3a2ef0.

📒 Files selected for processing (4)
  • cmd/workspace/up/agent.go
  • cmd/workspace/up/up.go
  • pkg/devcontainer/config/result.go
  • pkg/devcontainer/config/result_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Jul 18, 2026

Copy link
Copy Markdown

Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit d3a2ef0
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a5bb1e991e92600080b7361

@skevetter skevetter changed the title refactor(up): centralize agent result error reconciliation refactor(up): up command agent result error reconciliation Jul 19, 2026
@skevetter
skevetter merged commit 7010925 into main Jul 19, 2026
109 of 111 checks passed
@skevetter
skevetter deleted the refactor/validate-up-result branch July 19, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant