refactor(up): up command agent result error reconciliation#685
Conversation
Add config.Result.Err() and ErrNoAgentResult so the agent-forwarded structured error is resolved in one place, and split executeDevsyUp into validateUpResult + resolveWorkdir. Removes the duplicated `result.Error != ""` check in up.go and agent.go and drops executeDevsyUp below the cyclomatic-complexity threshold. No behavior change.
✅ Deploy Preview for devsydev canceled.
|
|
Warning Review limit reached
Next review available in: 6 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
Summary
Centralizes how the agent-forwarded structured error is reconciled with the transport error in the
uppath:config.Result.Err()(nil-safe) andErrNoAgentResult, so theresult.Error != ""handling lives in one place instead of being duplicated acrossup.goandagent.go.executeDevsyUpintovalidateUpResult(result/err reconciliation) andresolveWorkdir(workspace-folder resolution), dropping the function below the cyclomatic-complexity threshold.Result.Err().No behavior change.
Context
Extracted from #603 per review feedback to keep that PR focused on the
devsy cifeature. This is a prerequisite refactor and targetsmaindirectly.