Skip to content

fix(devcontainer): exclude synthesized devcontainer configs from git#729

Open
skevetter wants to merge 1 commit into
mainfrom
fix/exclude-synthesized-devcontainer
Open

fix(devcontainer): exclude synthesized devcontainer configs from git#729
skevetter wants to merge 1 commit into
mainfrom
fix/exclude-synthesized-devcontainer

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

When a devcontainer config is synthesized rather than imported from a path, the generated file was written to the workspace root but never added to .git/info/exclude, so it showed up as an untracked file (e.g. .devcontainer.devsy.json after passing an image reference).

Only the imported-path source (importExternalDevContainer) excluded its artifact. This adds the same excludeFromGit call to the two synthesizing paths:

  • saveSynthesizedConfig — used for image sources and --devcontainer-source none (writes .devcontainer.devsy.json)
  • getDefaultConfig — the auto-detection fallback (writes .devcontainer.json)

Both degrade gracefully outside a git repo and only log at debug on failure, matching the existing import path.

Adds TestSaveSynthesizedConfig_AddsGitExclude.

Synthesized configs written for image and auto-detected sources
(.devcontainer.devsy.json, .devcontainer.json) were never added to
.git/info/exclude, so they showed up as untracked files. Only the
imported-path source excluded its artifact. Add the exclude call to
saveSynthesizedConfig and getDefaultConfig so every generated config
is ignored.
@netlify

netlify Bot commented Jul 24, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit e67fd35
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a62e08264a901000889a3f5

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@skevetter, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1df8d377-a733-450b-8046-a31a9218cf04

📥 Commits

Reviewing files that changed from the base of the PR and between c07b339 and e67fd35.

📒 Files selected for processing (2)
  • pkg/devcontainer/config.go
  • pkg/devcontainer/import_external_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Jul 24, 2026

Copy link
Copy Markdown

Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit e67fd35
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a62e082809f6e000865db4f

@skevetter
skevetter marked this pull request as ready for review July 24, 2026 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant