fix(devcontainer): exclude synthesized devcontainer configs from git#729
fix(devcontainer): exclude synthesized devcontainer configs from git#729skevetter wants to merge 1 commit into
Conversation
Synthesized configs written for image and auto-detected sources (.devcontainer.devsy.json, .devcontainer.json) were never added to .git/info/exclude, so they showed up as untracked files. Only the imported-path source excluded its artifact. Add the exclude call to saveSynthesizedConfig and getDefaultConfig so every generated config is ignored.
✅ Deploy Preview for devsydev canceled.
|
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
Summary
When a devcontainer config is synthesized rather than imported from a path, the generated file was written to the workspace root but never added to
.git/info/exclude, so it showed up as an untracked file (e.g..devcontainer.devsy.jsonafter passing an image reference).Only the imported-path source (
importExternalDevContainer) excluded its artifact. This adds the sameexcludeFromGitcall to the two synthesizing paths:saveSynthesizedConfig— used for image sources and--devcontainer-source none(writes.devcontainer.devsy.json)getDefaultConfig— the auto-detection fallback (writes.devcontainer.json)Both degrade gracefully outside a git repo and only log at debug on failure, matching the existing import path.
Adds
TestSaveSynthesizedConfig_AddsGitExclude.