Deprecate array_first/array_last helpers in favor of Arr::first/Arr::last#24
Open
agissept wants to merge 3 commits into
Open
Deprecate array_first/array_last helpers in favor of Arr::first/Arr::last#24agissept wants to merge 3 commits into
agissept wants to merge 3 commits into
Conversation
…irst/Arr::last Replace all internal usages with Arr::first/Arr::last. The helper functions remain available but are marked @deprecated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
PHP 8.5 deprecates using null as an array offset. $namespace is null for non-namespaced config keys, so guard the afterLoad lookup. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
agissept
force-pushed
the
deprecate-array-first-last
branch
from
July 21, 2026 10:36
f8bc664 to
eb7c898
Compare
PHP 8.5 deprecates using null as an array offset. groupBy's key can resolve to null (closure or data_get returning null), so coalesce to an empty string. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
array_first()/array_last()withArr::first()/Arr::last()@deprecateduse Illuminate\Support\Arr;imports where missingTests in
tests/Support/SupportHelpersTest.phpintentionally still call the deprecated helpers to verify they keep working.Test plan
🤖 Generated with Claude Code