Set signedness of "char *" casts to avoid cross-platform differences.#9081
Open
rod-chapman wants to merge 4 commits into
Open
Set signedness of "char *" casts to avoid cross-platform differences.#9081rod-chapman wants to merge 4 commits into
rod-chapman wants to merge 4 commits into
Conversation
rod-chapman
requested review from
kroening,
peterschrammel,
remi-delmas-3000 and
tautschnig
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9081 +/- ##
===========================================
- Coverage 80.77% 80.77% -0.01%
===========================================
Files 1712 1712
Lines 189814 189815 +1
Branches 73 73
===========================================
Hits 153328 153328
- Misses 36486 36487 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rod-chapman
force-pushed
the
set-char-signedness-in-contracts
branch
2 times, most recently
from
9e6047c to
5ec1c8a
Compare
Explicitly cast to "unsigned char *" rather than "char *". This stabilizes the output GOTO and SMT on platforms where the default signedness of plain "char" is implementation-defined. Signed-off-by: Rod Chapman <rodchap@amazon.com>
This generates stable GOTO and (ultimately SMT) for all platforms where the default (implementation-defined) signedness of plain "char" is signed. Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
of memcpy(), memset() and memmove() instead of implementation-defined signedness of plain "char". This yields stable GOTO and SMT output on platforms where the default signnedness of "char" differs. Signed-off-by: Rod Chapman <rodchap@amazon.com>
rod-chapman
force-pushed
the
set-char-signedness-in-contracts
branch
from
9f4a421 to
34df576
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8991
Explicitly cast to "unsigned char *" rather than "char *". This stabilizes the output GOTO and SMT on platforms where the default signedness of plain "char" is implementation-defined.