Skip to content

use std::string_view in edit_distance#9097

Open
kroening wants to merge 1 commit into
developfrom
string_view_edit_distance
Open

use std::string_view in edit_distance#9097
kroening wants to merge 1 commit into
developfrom
string_view_edit_distance

Conversation

@kroening

@kroening kroening commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

The strings given as arguments to the methods in levenshtein_automatont are not copied, and their address is not taken. Hence, a std::string_view suffices.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The strings given as arguments to the methods in levenshtein_automatont are
not copied, and their address is not taken.  Hence, a std::string_view
suffices.
@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.77%. Comparing base (3163ab8) to head (c387140).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9097   +/-   ##
========================================
  Coverage    80.77%   80.77%           
========================================
  Files         1712     1712           
  Lines       189791   189814   +23     
  Branches        73       73           
========================================
+ Hits        153304   153325   +21     
- Misses       36487    36489    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants