use std::string_view for has_prefix, has_infix, has_suffix#9099
Draft
kroening wants to merge 1 commit into
Draft
use std::string_view for has_prefix, has_infix, has_suffix#9099kroening wants to merge 1 commit into
std::string_view for has_prefix, has_infix, has_suffix#9099kroening wants to merge 1 commit into
Conversation
cd81472 to
7c5728f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9099 +/- ##
========================================
Coverage 80.77% 80.78%
========================================
Files 1712 1712
Lines 189814 189822 +8
Branches 73 73
========================================
+ Hits 153324 153343 +19
+ Misses 36490 36479 -11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The has_prefix, has_infix, has_suffix functions do not copy the given strings, and hence, using std::string_view can be used to relieve the caller from constructing the std::string object.
7c5728f to
4268510
Compare
std::string_view for has_prefixstd::string_view for has_prefix, has_infix, has_suffix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
has_prefixfunction does not copy the given strings, and hence, usingstd::string_viewcan be used to relieve the caller from constructing thestd::stringobject.