use std::string_view for unicode.h functions#9100
Open
kroening wants to merge 1 commit into
Open
Conversation
Many of the functions only 'view' the string given, and hence, it the use of std::string_view may relieve the caller of the burden of constructing the std::string object.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9100 +/- ##
===========================================
+ Coverage 80.77% 80.78% +0.01%
===========================================
Files 1712 1712
Lines 189814 189814
Branches 73 73
===========================================
+ Hits 153324 153344 +20
+ Misses 36490 36470 -20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of the functions only 'view' the string given, and hence, it the use of
std::string_viewmay relieve the caller of the burden of constructing thestd::stringobject.