Add tests for kg, nlp, web-search, and ask modules#1
Open
shixish wants to merge 1 commit into
Open
Conversation
Cover the DQL/knowledge-graph code paths (dql params, raw output, parallel fan-out, ontology refresh) plus the previously untested option branches in entities(), webSearch(), and the ask() streaming/error/text-fallback paths. Raises overall coverage from ~76% to ~83% statements. Adds @vitest/coverage-v8 and a test:coverage script. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds test coverage for the knowledge-graph module and the previously untested option branches flagged in a coverage review.
crawl.tsis intentionally left as-is.tests/kg.test.ts—dql(params, option forwarding, json-format omission, raw bytes, auth error),dqlParallel(empty, order preservation, per-query options),dqlRefreshOntology(writes + creates dirs, error path)tests/nlp.test.ts— array unwrap, object passthrough, empty-array{},langdefault/overridetests/web-search.test.ts— bearer header + query,numResults/maxTokensbranches, error pathtests/ask.test.ts— payload/header, malformed/contentless chunk skipping, non-streaming text fallback, error-status pathAlso adds
@vitest/coverage-v8and atest:coveragescript.Coverage
kg.ts,nlp.ts,web-search.tsreach 100%;ask.ts100% stmts / 95.65% branch.Test plan
pnpm test— 48 passedpnpm test:coverage🤖 Generated with Claude Code