FIX: Several strings ignore the selected install-time culture and always render in English in Install Wizard - #7426
Open
idumlupinar wants to merge 13 commits into
Open
FIX: Several strings ignore the selected install-time culture and always render in English in Install Wizard#7426idumlupinar wants to merge 13 commits into
idumlupinar wants to merge 13 commits into
Conversation
Updates InstallWizard.aspx.cs to override the default DnnPaswordStrengthOptions text properties with local resource strings prior to JSON serialization.
Currently, the password strength meter reads from App_GlobalResources/WebControls.resx by default. During the initial installation phase, global resources cannot be relied upon to be fully translated for the user's selected culture. This change forces the password strength criteria and UI warnings to use the wizard's own local resource file, ensuring a fully localized experience that is consistent with the rest of the installation steps.
Technical Note:
The local resource overrides are intentionally applied before Json.Serialize(options). This ensures that the [OnSerializing] method on DnnPaswordStrengthOptions correctly applies string.Format to evaluate the {0} placeholders (for numeric values like minimum characters) against the newly localized strings before the JSON payload is generated.
Values copied verbatim from App_GlobalResources/WebControls.resx
Turkish localization for the missing strings
ConfirmPasswordUnmatched and ConfirmPasswordMatched strings added.
Added ConfirmPasswordUnmatched.Text and ConfirmPasswordMatched.Text values.
Added ConfirmPasswordUnmatched.Text and ConfirmPasswordMatched.Text values.
Previously, NoErrorsLogged message was always shown in English. This code aims fixing the issue.
…ll, so localization would silently fall back to default
Updated Turkish localization for various strings in the Installwizard.
valadas
approved these changes
Aug 4, 2026
valadas
left a comment
valadas
left a comment
Contributor
There was a problem hiding this comment.
Nothing sticks out to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7424
Summary
Fixes the Install Wizard's password-strength meter always rendering in English, regardless of the selected install-time culture, even when
InstallWizard.aspx.<culture>.resxis fully translated.Root cause
DnnPaswordStrengthOptions's constructor hardcodes its text source toApp_GlobalResources/WebControls.resxviaUtilities.GetLocalizedString. The Install Wizard runs before the rest of the application (including global resource translations for every culture) is guaranteed to be in place, so this dependency silently breaks localization for this one widget on this one page — every other string onInstallWizard.aspxalready correctly reads from the page's own local resource file. In addition, culture field inDNN Platform/Website/Install/InstallWizard.aspx.csdoesn't survive an AppDomain restart during install, so localization would silently fall back to default.Changes
InstallWizard.aspx.cs: after constructingDnnPaswordStrengthOptions, override itsMinLengthText,WeakText,FairText,StrongText,CriteriaAtLeastNCharsText,CriteriaAtLeastNSpecialCharsText,CriteriaValidationExpressionText, andPasswordRulesHeadTextfields using the page's existingLocalizeString()helper, before serialization.InstallWizard.aspx.resx(base) and all shippedInstallWizard.aspx.<culture>.resxfiles: added the corresponding resource keys, values copied/translated fromApp_GlobalResources/WebControls.resx.cultureCodeimplementationTesting performed
Notes for reviewers