feat(table): add web-style full cell grid for prettified tables - #259
Open
jinwei233 wants to merge 2 commits into
Open
feat(table): add web-style full cell grid for prettified tables#259jinwei233 wants to merge 2 commits into
jinwei233 wants to merge 2 commits into
Conversation
added 2 commits
August 8, 2026 17:19
Introduce `pi-coding-agent-table-full-grid' (default on) so prettified tables render a top border, an inter-row rule, and a bottom border with Unicode box-drawing characters, enclosing every cell like an HTML table. Border rules are woven into the existing per-raw-line display groups, so the group<->raw-line 1:1 invariant that `pi-coding-agent--decorate-table' relies on is preserved and overlay orchestration is untouched. Column widths are reused, so junctions align with the cell verticals, including zero-width columns. The option has no effect when prettify is disabled.
jinwei233
force-pushed
the
feat/table-full-grid
branch
from
August 9, 2026 02:21
093907b to
0e3944c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
pi-coding-agent-table-full-grid(default on) so prettified tables render a top border, an inter-row rule, and a bottom border using Unicode box-drawing characters — every cell is fully enclosed like an HTML table.Before:
After:
How
Border rules are woven into the existing per-raw-line display groups, so the group↔raw-line 1:1 invariant that
pi-coding-agent--decorate-tablerelies on is preserved and overlay orchestration is untouched. Column widths are reused, so junctions align with the cell verticals, including zero-width columns. The option has no effect whenpi-coding-agent-prettify-tablesis disabled.Testing
byte-compile-error-on-warn.