Skip to content

driver/kubernetes: enable gRPC keepalive to avoid infinite hangs #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pgimalac wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

driver/kubernetes: enable gRPC keepalive to avoid infinite hangs #3967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions driver/kubernetes/driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ import (
"github.com/moby/buildkit/client"
"github.com/pkg/errors"
"github.com/sirupsen/logrus"
"google.golang.org/grpc"
"google.golang.org/grpc/keepalive"
appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
Expand Down Expand Up @@ -394,11 +396,19 @@ func calculateBackoff(attempt int, baseDelay, maxDelay time.Duration) time.Durat
return min(time.Duration(1<<uint(attempt))*baseDelay, maxDelay)
}

// clientKeepaliveParams ensures that if the peer stops responding, the transport
// will eventually be closed and any reads/writes will be unblocked.
var clientKeepaliveParams = keepalive.ClientParameters{
Time: 20 * time.Second,
Timeout: 20 * time.Second,
}

func (d *Driver) Client(ctx context.Context, opts ...client.ClientOpt) (*client.Client, error) {
opts = append([]client.ClientOpt{
client.WithContextDialer(func(context.Context, string) (net.Conn, error) {
return d.Dial(ctx)
}),
client.WithGRPCDialOption(grpc.WithKeepaliveParams(clientKeepaliveParams)),
}, opts...)
return client.New(ctx, "", opts...)
}
Expand Down