Build fails when shared context directory contains non-ASCII characters#3972
Open
maxproske wants to merge 1 commit into
Open
Build fails when shared context directory contains non-ASCII characters#3972maxproske wants to merge 1 commit into
maxproske wants to merge 1 commit into
Conversation
Signed-off-by: Max Proske <max@mproske.com>
Closed
Author
|
Newbie question: if approved, worth me guarding downstream in buildkit too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially caught by docker/compose#13965 2 Compose services sharing a build context containing Chinese characters, but after some digging, every build dialed over gRPC fails. Same as #2793 which was closed as not reproducible.
Sanitize the shared key before it reaches gRPC.
Steps to reproduce:
All 3 fail with: