Skip to content

Run package typecheck against build config - #36

Open
Peter7896 wants to merge 1 commit into
dojo-engineering:mainfrom
Peter7896:peter7896/typecheck-exclude-examples
Open

Run package typecheck against build config#36
Peter7896 wants to merge 1 commit into
dojo-engineering:mainfrom
Peter7896:peter7896/typecheck-exclude-examples

Conversation

@Peter7896

@Peter7896 Peter7896 commented Jun 7, 2026

Copy link
Copy Markdown

Summary

  • point package-level npm run typecheck at tsconfig.build.json
  • reuse the existing build config that already excludes example and example-new-architecture
  • keep the root tsconfig.json unchanged while avoiding example app dependency failures during package typecheck

Validation

  • npm install --ignore-scripts --no-audit --no-fund --legacy-peer-deps
  • npm run typecheck

Fixes #33.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates tsconfig.json to exclude the example and example-new-architecture directories. The reviewer notes that this disables TypeScript type-checking and IntelliSense for these folders in IDEs and introduces redundancy with tsconfig.build.json. They suggest updating the typecheck script in package.json to use tsconfig.build.json instead.

Comment thread tsconfig.json Outdated
@Peter7896
Peter7896 force-pushed the peter7896/typecheck-exclude-examples branch from d097c0a to 88543ca Compare June 7, 2026 08:33
@Peter7896 Peter7896 changed the title Exclude example apps from root typecheck Run package typecheck against build config Jun 7, 2026
@Peter7896

Copy link
Copy Markdown
Author

Updated the branch to keep the root tsconfig.json unchanged and point the package typecheck script at tsconfig.build.json, which already carries the example app excludes.

npm run typecheck passes with this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm run typecheck incorrectly checks example app source files

1 participant