Run package typecheck against build config - #36
Open
Peter7896 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates tsconfig.json to exclude the example and example-new-architecture directories. The reviewer notes that this disables TypeScript type-checking and IntelliSense for these folders in IDEs and introduces redundancy with tsconfig.build.json. They suggest updating the typecheck script in package.json to use tsconfig.build.json instead.
Peter7896
force-pushed
the
peter7896/typecheck-exclude-examples
branch
from
June 7, 2026 08:33
d097c0a to
88543ca
Compare
Author
|
Updated the branch to keep the root
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run typecheckattsconfig.build.jsonexampleandexample-new-architecturetsconfig.jsonunchanged while avoiding example app dependency failures during package typecheckValidation
npm install --ignore-scripts --no-audit --no-fund --legacy-peer-depsnpm run typecheckFixes #33.