Update BenchmarkDotNet to 0.16.0-nightly.20260703.576#5258
Open
LoopedBard3 wants to merge 3 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
BenchmarkDotNet 0.16.0-nightly.20260703.576 upgrades Microsoft.Diagnostics.Runtime to 4.0.726401, which transitively requires Microsoft.Extensions.* >= 10.0.3 via Azure.Core 1.53.0. The net10.0 pin at 10.0.0 caused an NU1605 downgrade error during restore. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the repo’s BenchmarkDotNet dependency to a newer nightly build and adjusts the microbenchmark project’s Microsoft.Extensions.* package pin for net10.0 to avoid restore downgrade errors introduced by updated transitive dependencies.
Changes:
- Bump
BenchmarkDotNetVersionto0.16.0-nightly.20260703.576. - Update
MicroBenchmarks.csprojnet10.0ExtensionsVersionfrom10.0.0to10.0.3to resolve restore downgrade issues.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/Versions.props | Updates the centrally-defined BenchmarkDotNet version used across the repo. |
| src/benchmarks/micro/MicroBenchmarks.csproj | Adjusts net10.0 Microsoft.Extensions.* package version pin to keep restore consistent with updated BDN transitive requirements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…0.0.3 BenchmarkDotNet's transitive Microsoft.Diagnostics.Runtime -> Azure.Identity -> Azure.Core 1.53.0 requires Microsoft.Extensions.Primitives >= 10.0.3. Since Primitives is a direct PackageReference, NuGet flagged the net8.0/net9.0 pins (8.0.0/9.0.0) as a downgrade (NU1605). Float only Primitives to the transitive floor on those TFMs; implementation packages stay on their native versions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates BenchmarkDotNet from
0.16.0-nightly.20260518.1249to0.16.0-nightly.20260703.576(BDNmainHEAD, commit40736e96f0c528a4f90423e925d63fd7dd3f1bad).Changes
eng/Versions.props—BenchmarkDotNetVersion→0.16.0-nightly.20260703.576.src/benchmarks/micro/MicroBenchmarks.csproj— bump thenet10.0ExtensionsVersion10.0.0→10.0.3. BDN.576upgradesMicrosoft.Diagnostics.Runtimeto4.0.726401, which transitively requiresMicrosoft.Extensions.* >= 10.0.3viaAzure.Core 1.53.0; the10.0.0pin caused anNU1605downgrade error during restore.Verification
Ran both perf pipelines (702 fast, 1012 slow) pinning the runtime to a fixed baseline commit so BDN is the only variable, then compared against baseline via Kusto. No systematic measurement regression on any configuration:
WASM queues were validated separately against a runtime commit with a known-good WASM setup. All three WASM variants (interpreter/coreclr/AOT) are clean noise. Regression rates for the non-WASM configs sit at or below the main-to-main noise floor.
Verdict: no measurement impact — safe to merge.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com